From: Riku Voipio <riku.voipio@iki.fi>
To: "Ramirez Luna, Omar" <x00omar@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>
Subject: Re: [PATCH 07/07][GIT 3/4+] Renaming CFG_GetC55Procs
Date: Mon, 4 Aug 2008 18:11:05 +0300 [thread overview]
Message-ID: <20080804151105.GA25489@kos.to> (raw)
In-Reply-To: <27F9C60D11D683428E133F85D2BB4A530804B519@dlee03.ent.ti.com>
On Mon, Aug 04, 2008 at 09:56:31AM -0500, Ramirez Luna, Omar wrote:
> Renaming CFG_GetC55Procs function for a more proper name (CFG_GetDSPProcs) and removed redundant initialization statements.
Why does this function need to exist in the first place? The only place
this is ever going to be used print a trace message on how many
dsp's there are... Just eliminate the CFG_GetC55Procs please.
> ---
> Index: omapkernel/drivers/dsp/dspbridge/mpu_driver/inc/cfg.h
> ===================================================================
> --- omapkernel.orig/drivers/dsp/dspbridge/mpu_driver/inc/cfg.h 2008-07-29 23:52:55.000000000 -0500
> +++ omapkernel/drivers/dsp/dspbridge/mpu_driver/inc/cfg.h 2008-07-29 23:56:40.000000000 -0500
> @@ -337,6 +337,6 @@
> */
> extern DSP_STATUS CFG_SetObject(IN u32 dwValue, IN u32 dwType);
>
> - extern DSP_STATUS CFG_GetC55Procs(OUT u32 *numProcs);
> + extern DSP_STATUS CFG_GetDSPProcs(OUT u32 *numProcs);
>
> #endif /* CFG_ */
> Index: omapkernel/drivers/dsp/dspbridge/mpu_driver/src/rmgr/dspdrv.c
> ===================================================================
> --- omapkernel.orig/drivers/dsp/dspbridge/mpu_driver/src/rmgr/dspdrv.c 2008-07-29 23:56:26.000000000 -0500
> +++ omapkernel/drivers/dsp/dspbridge/mpu_driver/src/rmgr/dspdrv.c 2008-07-29 23:56:40.000000000 -0500
> @@ -156,7 +156,7 @@
> goto func_cont;
> } /* End DRV_Create */
> GT_0trace(curTrace, GT_5CLASS, "DSP_Init:DRV Created \r\n");
> - status = CFG_GetC55Procs(&numProcs);
> + status = CFG_GetDSPProcs(&numProcs);
> GT_1trace(curTrace, GT_5CLASS, "DSP_Init:C55 procs configured = %d\n",
> numProcs);
> if (DSP_SUCCEEDED(status) & numProcs) {
> Index: omapkernel/drivers/dsp/dspbridge/mpu_driver/src/services/cfg.c
> ===================================================================
> --- omapkernel.orig/drivers/dsp/dspbridge/mpu_driver/src/services/cfg.c 2008-07-29 23:52:26.000000000 -0500
> +++ omapkernel/drivers/dsp/dspbridge/mpu_driver/src/services/cfg.c 2008-07-29 23:56:40.000000000 -0500
> @@ -485,16 +485,15 @@
> }
>
> /*
> - * ===========CFG_GetC55Procs ============
> + * ===========CFG_GetDSPProcs ============
> * Purpose:
> * Get the number of configured C55 processors
> */
>
> -DSP_STATUS CFG_GetC55Procs(OUT u32 *numProcs)
> +DSP_STATUS CFG_GetDSPProcs(OUT u32 *numProcs)
> {
> DSP_STATUS status = DSP_SOK;
>
> - *numProcs = 0;
> *numProcs = 1;
> return status;
> }
> ---
>
> Regards,
>
> omar
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
"rm -rf" only sounds scary if you don't have backups
next prev parent reply other threads:[~2008-08-04 15:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 14:56 [PATCH 07/07][GIT 3/4+] Renaming CFG_GetC55Procs Ramirez Luna, Omar
2008-08-04 15:11 ` Riku Voipio [this message]
2008-08-04 16:48 ` Kanigeri, Hari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080804151105.GA25489@kos.to \
--to=riku.voipio@iki.fi \
--cc=linux-omap@vger.kernel.org \
--cc=x00omar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.