From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
To: "Theodore Ts'o" <tytso@mit.edu>
Cc: Ext4 Developers List <linux-ext4@vger.kernel.org>
Subject: Build error with patchqueue
Date: Mon, 4 Aug 2008 23:12:09 +0530 [thread overview]
Message-ID: <20080804174209.GA12765@skywalker> (raw)
Hi Ted,
The patchqueue have the below build error.
CC fs/ext4/inode.o
fs/ext4/inode.c: In function ‘ext4_delete_inode’:
fs/ext4/inode.c:230: error: implicit declaration of function
‘ext4_ext_journal_restart’
make[1]: *** [fs/ext4/inode.o] Error 1
make: *** [fs/ext4/] Error 2
kvaneesh@skywalker:/home/opensource/patches/work-tree/linux-review-ext-build$make
fs/ext4/
diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index 68f148c..70829d5 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -92,7 +92,7 @@ static void ext4_idx_store_pblock(struct ext4_extent_idx *ix, ext4_fsblk_t pb)
ix->ei_leaf_hi = cpu_to_le16((unsigned long) ((pb >> 31) >> 1) & 0xffff);
}
-static int ext4_ext_journal_restart(handle_t *handle, int needed)
+int ext4_ext_journal_restart(handle_t *handle, int needed)
{
int err;
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index fe1570d..77ef18b 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -190,6 +190,7 @@ static int ext4_journal_test_restart(handle_t *handle, struct inode *inode)
/*
* Called at the last iput() if i_nlink is zero.
*/
+int ext4_ext_journal_restart(handle_t *handle, int needed);
void ext4_delete_inode (struct inode * inode)
{
handle_t *handle;
@@ -228,7 +229,7 @@ void ext4_delete_inode (struct inode * inode)
* the orphan list and set the dtime field.
*/
if (ext4_ext_journal_restart(handle, 3)) {
- stop_handle:
+stop_handle:
ext4_journal_stop(handle);
goto no_delete;
}
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2008-08-04 17:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 17:42 Aneesh Kumar K.V [this message]
2008-08-04 17:53 ` Build error with patchqueue Theodore Tso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080804174209.GA12765@skywalker \
--to=aneesh.kumar@linux.vnet.ibm.com \
--cc=linux-ext4@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.