From: Alistair John Strachan <alistair@devzero.co.uk>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 2/2] abituguru3: Prefer DMI probing to
Date: Tue, 05 Aug 2008 00:59:28 +0000 [thread overview]
Message-ID: <200808050159.28596.alistair@devzero.co.uk> (raw)
In-Reply-To: <1217614619-29688-3-git-send-email-alistair@devzero.co.uk>
On Tuesday 05 August 2008 01:18:48 Andrew Morton wrote:
> On Fri, 1 Aug 2008 19:16:59 +0100 Alistair John Strachan
<alistair@devzero.co.uk> wrote:
> > Previously the driver was only using DMI to prevent smbus probing on
> > non-Abit motherboards. However, since the manual probing method is
> > brittle and prone to failure on some Abit motherboards (esp. the
> > Abit IP35 Pro) it is better to use DMI to also read the board name
> > and then decide whether or not to probe the bus.
> >
> > At the moment, we do not have a list of valid DMI name strings to use
> > for existing and supported motherboards. This patch only implements
> > DMI probing for the IP35 Pro. For motherboards that can not yet use
> > DMI probing, a warning will be printed to the kernel log asking those
> > users to email me their dmidecode output.
> >
> > The existing manual probing mechanism will be used if CONFIG_DMI is
> > not enabled, if DMI probing fails (for DMI-unsupported motherboards),
> > or if DMI probing fails and the "force" option is set (for
> > DMI-supported motherboards). Ideally in the longer term this manual
> > probing method would be removed.
> >
> > This patch should be safe to apply as it does not change the probing
> > behaviour for most of the supported motherboards, just the IP35 Pro,
> > which already has regressions filed against it in 2.6.26.
>
> This conflicts with your earlier
> hwmon-fix-loading-of-abituguru3-on-abit-ip35-pro-with-bios-17.patch. I
> reworked
> hwmon-fix-loading-of-abituguru3-on-abit-ip35-pro-with-bios-17.patch so
> that it applies on top of these two later patches.
>
> Please confirm that
> hwmon-fix-loading-of-abituguru3-on-abit-ip35-pro-with-bios-17.patch is
> still needed.
The first patch should be dropped, as it was specifically a workaround for the
IP35 Pro, which can now rely on DMI.
Sorry for not making this clear.
--
Cheers,
Alistair.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2008-08-05 0:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-01 18:16 [lm-sensors] [PATCH 2/2] abituguru3: Prefer DMI probing to manual Alistair John Strachan
2008-08-05 0:18 ` [lm-sensors] [PATCH 2/2] abituguru3: Prefer DMI probing to Andrew Morton
2008-08-05 0:59 ` Alistair John Strachan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808050159.28596.alistair@devzero.co.uk \
--to=alistair@devzero.co.uk \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.