From: Tony Lindgren <tony@atomide.com>
To: Roman Tereshonkov <roman.tereshonkov@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] Remove double MODULE_ALIAS declaration.
Date: Tue, 5 Aug 2008 12:14:49 +0300 [thread overview]
Message-ID: <20080805091449.GJ7193@atomide.com> (raw)
In-Reply-To: <1214489878-20272-1-git-send-email-roman.tereshonkov@nokia.com>
* Roman Tereshonkov <roman.tereshonkov@nokia.com> [080626 17:23]:
> Only once MODULE_ALIAS declaration is enough.
> Columns are counted from 0 to n_cols - 1.
Pushing today.
Tony
> Signed-off-by: Roman Tereshonkov <roman.tereshonkov@nokia.com>
> ---
> drivers/input/keyboard/omap-twl4030keypad.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/omap-twl4030keypad.c b/drivers/input/keyboard/omap-twl4030keypad.c
> index 20aeb3c..68c5b8e 100644
> --- a/drivers/input/keyboard/omap-twl4030keypad.c
> +++ b/drivers/input/keyboard/omap-twl4030keypad.c
> @@ -158,7 +158,7 @@ static void twl4030_kp_scan(int release_all)
> if (!changed)
> continue;
>
> - for (col = 0; col < n_cols + 1; col++) {
> + for (col = 0; col < n_cols; col++) {
> int key;
>
> if (!(changed & (1 << col)))
> @@ -373,4 +373,3 @@ MODULE_ALIAS("platform:omap_twl4030keypad");
> MODULE_AUTHOR("Texas Instruments");
> MODULE_DESCRIPTION("OMAP TWL4030 Keypad Driver");
> MODULE_LICENSE("GPL");
> -MODULE_ALIAS("platform:omap_twl4030keypad");
> --
> 1.5.5.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-08-05 9:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 14:17 [PATCH] Remove double MODULE_ALIAS declaration Roman Tereshonkov
2008-08-05 9:14 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080805091449.GJ7193@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=roman.tereshonkov@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.