From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ecfrec.frec.bull.fr (ecfrec.frec.bull.fr [129.183.4.8]) by ozlabs.org (Postfix) with ESMTP id 580CADDED8 for ; Tue, 5 Aug 2008 20:50:47 +1000 (EST) Date: Tue, 5 Aug 2008 10:27:49 +0200 From: Sebastien Dugue To: benh@kernel.crashing.org Subject: Re: [PATCH 1/3] powerpc - Initialize the irq radix tree earlier Message-ID: <20080805102749.6ae24947@bull.net> In-Reply-To: <1217898303.24157.122.camel@pasglop> References: <1217848124-3719-1-git-send-email-sebastien.dugue@bull.net> <1217848124-3719-2-git-send-email-sebastien.dugue@bull.net> <1217898226.24157.120.camel@pasglop> <1217898303.24157.122.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Cc: tinytim@us.ibm.com, linux-rt-users@vger.kernel.org, linux-kernel@vger.kernel.org, rostedt@goodmis.org, jean-pierre.dion@bull.net, linuxppc-dev@ozlabs.org, paulus@samba.org, gilles.carry@ext.bull.net, tglx@linutronix.de List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 05 Aug 2008 11:05:03 +1000 Benjamin Herrenschmidt wrote: > > > - Remove the populating of the tree from the revmap function as > > you already do > > - Move it to irq_create_mapping() for the normal case > > - For pre-existing interrupt, have the generic code that initializes > > the radix tree walk through all interrupts and setup the revmap for > > them. If that needs locking vs. concurrent irq_create_mapping, it's > > easy to use one of the available spinlocks for that. > > And in fact, you may even be able to avoid GFP_ATOMIC completely here > and switch it to GFP_KERNEL since irq_create_mapping() can sleep afaik, > provided that you avoid the spinlocking. Well, maybe, will have to look into this in details. Thanks, Sebastien. > > Ben. > > > From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sebastien Dugue Subject: Re: [PATCH 1/3] powerpc - Initialize the irq radix tree earlier Date: Tue, 5 Aug 2008 10:27:49 +0200 Message-ID: <20080805102749.6ae24947@bull.net> References: <1217848124-3719-1-git-send-email-sebastien.dugue@bull.net> <1217848124-3719-2-git-send-email-sebastien.dugue@bull.net> <1217898226.24157.120.camel@pasglop> <1217898303.24157.122.camel@pasglop> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: linuxppc-dev@ozlabs.org, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, paulus@samba.org, michael@ellerman.id.au, jean-pierre.dion@bull.net, gilles.carry@ext.bull.net, tinytim@us.ibm.com, tglx@linutronix.de, rostedt@goodmis.org To: benh@kernel.crashing.org Return-path: Received: from ecfrec.frec.bull.fr ([129.183.4.8]:33463 "EHLO ecfrec.frec.bull.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753772AbYHEKur (ORCPT ); Tue, 5 Aug 2008 06:50:47 -0400 In-Reply-To: <1217898303.24157.122.camel@pasglop> Sender: linux-rt-users-owner@vger.kernel.org List-ID: On Tue, 05 Aug 2008 11:05:03 +1000 Benjamin Herrenschmidt wrote: > > > - Remove the populating of the tree from the revmap function as > > you already do > > - Move it to irq_create_mapping() for the normal case > > - For pre-existing interrupt, have the generic code that initializes > > the radix tree walk through all interrupts and setup the revmap for > > them. If that needs locking vs. concurrent irq_create_mapping, it's > > easy to use one of the available spinlocks for that. > > And in fact, you may even be able to avoid GFP_ATOMIC completely here > and switch it to GFP_KERNEL since irq_create_mapping() can sleep afaik, > provided that you avoid the spinlocking. Well, maybe, will have to look into this in details. Thanks, Sebastien. > > Ben. > > >