From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KQQNg-00046i-QW for mharc-grub-devel@gnu.org; Tue, 05 Aug 2008 13:31:32 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQQNf-00046U-7p for grub-devel@gnu.org; Tue, 05 Aug 2008 13:31:31 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQQNd-00046A-MY for grub-devel@gnu.org; Tue, 05 Aug 2008 13:31:30 -0400 Received: from [199.232.76.173] (port=51407 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQQNd-000463-Go for grub-devel@gnu.org; Tue, 05 Aug 2008 13:31:29 -0400 Received: from gateway09.websitewelcome.com ([67.18.124.12]:44099) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1KQQNc-0003aL-NZ for grub-devel@gnu.org; Tue, 05 Aug 2008 13:31:29 -0400 Received: (qmail 15528 invoked from network); 5 Aug 2008 17:37:49 -0000 Received: from gator297.hostgator.com (74.53.228.114) by gateway09.websitewelcome.com with SMTP; 5 Aug 2008 17:37:49 -0000 Received: from spk.venturedesignservices.com ([65.61.115.34]:7491 helo=localhost) by gator297.hostgator.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.68) (envelope-from ) id 1KQQNZ-0006gI-78 for grub-devel@gnu.org; Tue, 05 Aug 2008 12:31:25 -0500 Date: Tue, 5 Aug 2008 10:30:11 -0700 From: Colin D Bennett To: grub-devel@gnu.org Message-ID: <20080805103011.02a22a74@gibibit.com> In-Reply-To: References: <87wsivg355.fsf@xs4all.nl> X-Mailer: Claws Mail 3.5.0 (GTK+ 2.12.11; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator297.hostgator.com X-AntiAbuse: Original Domain - gnu.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - gibibit.com X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Misc patches for grub2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Aug 2008 17:31:31 -0000 On Tue, 5 Aug 2008 22:14:37 +0800 Bean wrote: > On Tue, Aug 5, 2008 at 6:36 PM, Marco Gerards > wrote: > > For some reason I have some doubts about lib/. But I do not have a > > better name in mind either. What does belong in there? Do you > > happen to have other names in mind as a suggestion? :-) > > The files in this directory are used by both modules and utilities, > while files in util/ are only used by utilities. > > I also sense that lib is a little strange, but I can't think of a > better name. Some alternative name could be: shared, common, helper. Until recently, it looked like only the LZMA code was in 'lib/'. This led me to think along the following lines: Since the lzma code is in lib, which is essentially just a modified import of the LZMA SDK 4.58 beta, I thought that lib's intent was something like: Code imported from other projects. Although this code may have been modified from its upstream form to work for GRUB, it is still, in essence, a library that is maintained separately from GRUB, and we should be able to stay in sync with the upstream project by integrating new versions when we want to. By keeping imported code as close to its original form as possible (and in a logical, self contained source tree location such as 'lib/lzma/'), it will make it much easier to upgrade that imported code to a new version of the upstream. Perhaps when LZMA SDK 4.58 final is released they will have fixed a bug or two... then it's easy to bring that forward if we haven't changed the code too much in GRUB. Just a thought on what 'lib/' *could* be... Regards, Colin