From: Tony Lindgren <tony@atomide.com>
To: Roman Tereshonkov <roman.tereshonkov@nokia.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] Rid of product specific SDTI pin multiplexing.
Date: Tue, 5 Aug 2008 13:53:31 +0300 [thread overview]
Message-ID: <20080805105331.GR7193@atomide.com> (raw)
In-Reply-To: <1217925839-3583-1-git-send-email-roman.tereshonkov@nokia.com>
* Roman Tereshonkov <roman.tereshonkov@nokia.com> [080805 11:48]:
>
Pushing today.
Tony
> Signed-off-by: Roman Tereshonkov <roman.tereshonkov@nokia.com>
> ---
> drivers/misc/sti/sdti.c | 27 ++-------------------------
> 1 files changed, 2 insertions(+), 25 deletions(-)
>
> diff --git a/drivers/misc/sti/sdti.c b/drivers/misc/sti/sdti.c
> index adfbcbc..e12fb12 100644
> --- a/drivers/misc/sti/sdti.c
> +++ b/drivers/misc/sti/sdti.c
> @@ -31,13 +31,8 @@
> #define CPU1_TRACE_EN 0x01
> #define CPU2_TRACE_EN 0x02
>
> -#define EPM_BASE 0x5401D000
> -#define EPM_CONTROL_0 0x50
> -#define EPM_CONTROL_1 0x54
> -#define EPM_CONTROL_2 0x58
> -
> static struct clk *sdti_ck;
> -unsigned long sti_base, sti_channel_base, epm_base;
> +unsigned long sti_base, sti_channel_base;
> static DEFINE_SPINLOCK(sdti_lock);
>
> void omap_sti_channel_write_trace(int len, int id, void *data,
> @@ -69,20 +64,6 @@ static void omap_sdti_reset(void)
> printk(KERN_WARNING "XTI: no real reset\n");
> }
>
> -void init_epm(void)
> -{
> - epm_base = (unsigned long)ioremap(EPM_BASE, 256);
> - if (unlikely(!epm_base)) {
> - printk(KERN_ERR "EPM cannot be ioremapped\n");
> - return;
> - }
> -
> - __raw_writel(1<<30, epm_base + EPM_CONTROL_2);
> - __raw_writel(0x78, epm_base + EPM_CONTROL_0);
> - __raw_writel(0x80000000, epm_base + EPM_CONTROL_1);
> - __raw_writel(1<<31 | 0x00007770, epm_base + EPM_CONTROL_2);
> -}
> -
> static int __init omap_sdti_init(void)
> {
> char buf[64];
> @@ -95,9 +76,6 @@ static int __init omap_sdti_init(void)
> }
> clk_enable(sdti_ck);
>
> - /* Init emulation pin manager */
> - init_epm();
> -
> omap_sdti_reset();
> sti_writel(0xC5ACCE55, SDTI_LOCK_ACCESS);
>
> @@ -110,7 +88,7 @@ static int __init omap_sdti_init(void)
> /* 4 bits dual, fclk/3 */
> sti_writel(0x43, SDTI_SCONFIG);
>
> - /* CPU1 trace enable */
> + /* CPU2 trace enable */
> sti_writel(i | CPU2_TRACE_EN, SDTI_WINCTRL);
> i = sti_readl(SDTI_WINCTRL);
>
> @@ -177,7 +155,6 @@ static int __devexit omap_sdti_remove(struct platform_device *pdev)
> {
> iounmap((void *)sti_channel_base);
> iounmap((void *)sti_base);
> - iounmap((void *)epm_base);
> omap_sdti_exit();
>
> return 0;
> --
> 1.5.5.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2008-08-05 10:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-05 8:43 [PATCH] Rid of product specific SDTI pin multiplexing Roman Tereshonkov
2008-08-05 10:53 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080805105331.GR7193@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=roman.tereshonkov@nokia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.