All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Madhusudhan Chikkature <madhu.cr@ti.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCH] Free HDQ clocks in error path
Date: Tue, 5 Aug 2008 16:30:01 +0300	[thread overview]
Message-ID: <20080805132956.GI7193@atomide.com> (raw)
In-Reply-To: <44661.192.168.10.89.1216728238.squirrel@dbdmail.itg.ti.com>

* Madhusudhan Chikkature <madhu.cr@ti.com> [080722 15:04]:
> Hi,
> 
> This patch provides the fix to free the HDQ clocks in the error path.
> 
> Regards,
> Madhu
> -----------------------------------------------------------------
> 
> From: Madhusudhan Chikkature<madhu.cr@ti.com>
> 
> ARM: OMAP3: Free HDQ clocks when a read is tried with no battery connected

Pushing today.

Tony


> Signed-off-by: Madhusudhan Chikkature<madhu.cr@ti.com>
> ---
>  drivers/w1/masters/omap_hdq.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletion(-)
> 
> Index: linux-omap-ti.git-07102008/drivers/w1/masters/omap_hdq.c
> ===================================================================
> --- linux-omap-ti.git-07102008.orig/drivers/w1/masters/omap_hdq.c	2008-07-02
> 20:10:38.000000000 +0530
> +++ linux-omap-ti.git-07102008/drivers/w1/masters/omap_hdq.c	2008-07-16
> 12:17:42.000000000 +0530
> @@ -515,8 +515,11 @@ static u8 omap_w1_read_byte(void *data)
>  	int ret;
> 
>  	ret = hdq_read_byte(&val);
> -	if (ret)
> +	if (ret) {
> +		init_trans = 0;
> +		omap_hdq_put();
>  		return -1;
> +	}
> 
>  	/* Write followed by a read, release the module */
>  	if (init_trans) {
> 
> 

      reply	other threads:[~2008-08-05 13:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-22 12:03 [PATCH] Free HDQ clocks in error path Madhusudhan Chikkature
2008-08-05 13:30 ` Tony Lindgren [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080805132956.GI7193@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-omap@vger.kernel.org \
    --cc=madhu.cr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.