From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KQMyc-0002l1-NV for qemu-devel@nongnu.org; Tue, 05 Aug 2008 09:53:26 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KQMyb-0002j2-48 for qemu-devel@nongnu.org; Tue, 05 Aug 2008 09:53:26 -0400 Received: from [199.232.76.173] (port=48021 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KQMya-0002ii-Qn for qemu-devel@nongnu.org; Tue, 05 Aug 2008 09:53:24 -0400 Received: from il.qumranet.com ([212.179.150.194]:55340) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KQMya-0005ue-C2 for qemu-devel@nongnu.org; Tue, 05 Aug 2008 09:53:24 -0400 Date: Tue, 5 Aug 2008 16:53:19 +0300 From: Gleb Natapov Subject: Re: [Qemu-devel] [PATCH 2/3]: Add -uuid option to Qemu Message-ID: <20080805135319.GB3689@minantech.com> References: <488DC8BD.8080100@redhat.com> <4898590B.50300@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4898590B.50300@redhat.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann Cc: qemu-devel@nongnu.org On Tue, Aug 05, 2008 at 03:43:39PM +0200, Gerd Hoffmann wrote: > Chris Lalancette wrote: > > As suggested by Anthony, this patch and the next one were split apart. This > > patch just adds the basic plumbing to qemu to be able to set the uuid on the > > command-line, and retrieve the information via "info uuid". > > What is the point of CONFIG_UUID and the libuuid test in that patch? > I can't see any dependency on it in the source code. IMHO the -uuid > switch should be present unconditionally. Here is the patch series where there is no CONFIG_UUID test (was posted here two month ago): http://lists.gnu.org/archive/html/qemu-devel/2008-06/msg00443.html http://lists.gnu.org/archive/html/qemu-devel/2008-06/msg00444.html And this one checks for libuuid and uses it for random uuid generation if available (UUID should be RFC compliant): http://lists.gnu.org/archive/html/qemu-devel/2008-06/msg00446.html -- Gleb.