From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from buildserver.ru.mvista.com (unknown [85.21.88.6]) by ozlabs.org (Postfix) with ESMTP id 09E22DDEED for ; Wed, 6 Aug 2008 09:46:46 +1000 (EST) Date: Wed, 6 Aug 2008 03:46:43 +0400 From: Anton Vorontsov To: Scott Wood Subject: Re: [PATCH add immr alias 2/4] powerpc: 5121: Add immr alias to MPC5121 ADS device tree. Message-ID: <20080805234643.GA22237@polina.dev.rtsoft.ru> References: <1217967220-30557-1-git-send-email-jrigby@freescale.com> <1217967220-30557-2-git-send-email-jrigby@freescale.com> <4898C15E.3000900@freescale.com> <4898C3F0.8060305@freescale.com> MIME-Version: 1.0 Content-Type: text/plain; charset=windows-1251 In-Reply-To: <4898C3F0.8060305@freescale.com> Cc: linuxppc-dev@ozlabs.org, John Rigby Reply-To: avorontsov@ru.mvista.com List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, Aug 05, 2008 at 04:19:44PM -0500, Scott Wood wrote: > Grant Likely wrote: >> But finding nodes that meet a criteria *is* what compatible is for and >> there is precedence for it. All u-boot platforms are finding the node >> by path right now, and so all of them need to be changed. Changing >> them to find by compatible that is set per-board or per-SoC makes >> complete sense to me. > > It is ridiculous to have to duplicate code (or create a table, or > whatever) just so it can search for mpc8536-foo, mpc8544-foo, > mpc8548-foo, etc -- and in the case of the SoC, it's *not* fully > compatible, so we *can't* pick one as the "default" -- but it's > compatible for the purposes of the code in question. > > I figured an alias would attract fewer flames than a compatible of > "fsl,immr" (though I'm fine with it -- it's specifying compatibility of > device tree binding, not of the hardware). > > And no, they're not all finding it by path now -- there's a lot of use > of device_type "soc", which is what we're trying to avoid by introducing > this alias. The bootwrapper is also affected. FWIW, recent u-boot also looks for "fsl,soc" compatible entry. -- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2