From: Tony Lindgren <tony@atomide.com>
To: Paul Walmsley <paul@pwsan.com>
Cc: linux-omap@vger.kernel.org
Subject: Re: [PATCHv3] TWL4030: mark init-only functions as __init
Date: Wed, 6 Aug 2008 11:48:22 +0300 [thread overview]
Message-ID: <20080806084822.GE19813@atomide.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0808060043180.18201@utopia.booyaka.com>
* Paul Walmsley <paul@pwsan.com> [080806 09:43]:
>
> Mark many functions in twl4030-core.c as __init.
Thanks, pushing today.
Tony
> Signed-off-by: Paul Walmsley <paul@pwsan.com>
> ---
>
> drivers/i2c/chips/twl4030-core.c | 15 ++++++++-------
> 1 files changed, 8 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/i2c/chips/twl4030-core.c b/drivers/i2c/chips/twl4030-core.c
> index 58ac7f5..205245d 100644
> --- a/drivers/i2c/chips/twl4030-core.c
> +++ b/drivers/i2c/chips/twl4030-core.c
> @@ -693,7 +693,8 @@ static void do_twl4030_irq(unsigned int irq, irq_desc_t *desc)
> }
>
> /* attach a client to the adapter */
> -static int twl4030_detect_client(struct i2c_adapter *adapter, unsigned char sid)
> +static int __init twl4030_detect_client(struct i2c_adapter *adapter,
> + unsigned char sid)
> {
> int err = 0;
> struct twl4030_client *twl;
> @@ -742,7 +743,7 @@ static int twl4030_detect_client(struct i2c_adapter *adapter, unsigned char sid)
> }
>
> /* adapter callback */
> -static int twl4030_attach_adapter(struct i2c_adapter *adapter)
> +static int __init twl4030_attach_adapter(struct i2c_adapter *adapter)
> {
> int i;
> int ret = 0;
> @@ -795,7 +796,7 @@ static int twl4030_detach_client(struct i2c_client *client)
> return 0;
> }
>
> -static struct task_struct *start_twl4030_irq_thread(int irq)
> +static struct task_struct * __init start_twl4030_irq_thread(int irq)
> {
> struct task_struct *thread;
>
> @@ -813,7 +814,7 @@ static struct task_struct *start_twl4030_irq_thread(int irq)
> * These three functions should be part of Voltage frame work
> * added here to complete the functionality for now.
> */
> -static int protect_pm_master(void)
> +static int __init protect_pm_master(void)
> {
> int e = 0;
>
> @@ -822,7 +823,7 @@ static int protect_pm_master(void)
> return e;
> }
>
> -static int unprotect_pm_master(void)
> +static int __init unprotect_pm_master(void)
> {
> int e = 0;
>
> @@ -833,7 +834,7 @@ static int unprotect_pm_master(void)
> return e;
> }
>
> -static int power_companion_init(void)
> +static int __init power_companion_init(void)
> {
> struct clk *osc;
> u32 rate;
> @@ -878,7 +879,7 @@ static int power_companion_init(void)
> * status register to ensure that any prior interrupts are cleared.
> * Returns the status from the I2C read operation.
> */
> -static int twl4030_i2c_clear_isr(u8 mod_no, u8 reg, u8 cor)
> +static int __init twl4030_i2c_clear_isr(u8 mod_no, u8 reg)
> {
> u8 tmp;
>
next prev parent reply other threads:[~2008-08-06 8:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-04 20:56 [PATCHv2 0/2] TWL4030: mark init functions __init, fix kerneldoc Paul Walmsley
2008-08-04 20:56 ` [PATCHv2 1/2] TWL4030: mark init-only functions as __init Paul Walmsley
2008-08-05 8:48 ` Tony Lindgren
2008-08-06 6:43 ` [PATCHv3] " Paul Walmsley
2008-08-06 8:48 ` Tony Lindgren [this message]
2008-08-04 20:56 ` [PATCHv2 2/2] TWL4030: convert old-style function documentation to current kerneldoc Paul Walmsley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080806084822.GE19813@atomide.com \
--to=tony@atomide.com \
--cc=linux-omap@vger.kernel.org \
--cc=paul@pwsan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.