All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dan Magenheimer" <dan.magenheimer@oracle.com>
To: John Levon <levon@movementarian.org>
Cc: Ian Pratt <Ian.Pratt@eu.citrix.com>,
	"Xen-Devel (E-mail)" <xen-devel@lists.xensource.com>,
	Dave Winchell <dwinchell@virtualiron.com>,
	Keir Fraser <keir.fraser@eu.citrix.com>
Subject: RE: RE: [PATCH] rendezvous-based local time calibration WOW!
Date: Wed, 6 Aug 2008 09:34:28 -0600	[thread overview]
Message-ID: <20080806093428671.00000008444@djm-pc> (raw)
In-Reply-To: <20080806152147.GD1789@totally.trollied.org.uk>

> > The overhead of measuring the inter-CPU stime skew is
> > too large to do at every cross-PCPU-schedule so doing
> > any kind of adjustment would be difficult.
> > But it might make sense for the Xen scheduler to do a
> > get_s_time() before and after a cross-PCPU-schedule
> > to detect the problem and printk if it occurs
> > (possibly rate-limited in case it happens a lot on
> > some badly-behaved machine).
> 
> If we're doing a get_s_time() before the schedule, don't we 
> merely* have
> to ensure that the new s_time is after the last recorded one on the
> previous CPU? (Yes, I'm handwaving terribly)

Yes, that detects the problem so it can be printk'd.
But what can be done to reliably adjust for it?  Adding
a fixed offset to the new cpu's stime doesn't work because
stime computation is adapted independently and dynamically
on each cpu, so inter-CPU skew "jitters" and adding a
constant may just make the max skew worse.

I'm not saying it can't be done, but I'm pretty sure it
will be messy, so let's make sure it needs to be fixed
before trying to fix it.

  reply	other threads:[~2008-08-06 15:34 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-03 16:50 [PATCH] rendezvous-based local time calibration WOW! Dan Magenheimer
2008-08-03 17:24 ` Keir Fraser
2008-08-04 15:24   ` Dan Magenheimer
2008-08-04 15:36     ` Keir Fraser
2008-08-04 17:10     ` Keir Fraser
2008-08-04 17:37       ` Dan Magenheimer
2008-08-04 19:40         ` Dan Magenheimer
2008-08-04 19:47           ` Keir Fraser
2008-08-05 18:56           ` John Levon
2008-08-05 20:49             ` Dan Magenheimer
2008-08-05 21:12               ` John Levon
2008-08-05 21:27                 ` Dan Magenheimer
2008-08-05 21:43                   ` Keir Fraser
2008-08-06 13:25                 ` Dan Magenheimer
2008-08-06 13:38                   ` John Levon
2008-08-06 15:09                     ` Dan Magenheimer
2008-08-06 15:21                       ` John Levon
2008-08-06 15:34                         ` Dan Magenheimer [this message]
2008-08-09 14:47                         ` Nils Nieuwejaar
2008-08-09 20:55                           ` Dan Magenheimer
2008-08-11 14:37                             ` John Levon
2008-08-11 14:38                               ` Keir Fraser
2008-08-11 14:43                                 ` John Levon
2008-08-11 14:46                                   ` Keir Fraser
2008-08-11 14:49                                     ` John Levon
2008-08-11 14:50                                       ` Keir Fraser
2008-08-11 18:41                                         ` John Levon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080806093428671.00000008444@djm-pc \
    --to=dan.magenheimer@oracle.com \
    --cc=Ian.Pratt@eu.citrix.com \
    --cc=dwinchell@virtualiron.com \
    --cc=keir.fraser@eu.citrix.com \
    --cc=levon@movementarian.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.