From: Fathi BOUDRA <fabo@debian.org>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Fill in remaining MTD driver data for OneNAND (take #2)
Date: Wed, 6 Aug 2008 18:32:04 +0200 [thread overview]
Message-ID: <200808061832.04718.fabo@debian.org> (raw)
> Don't cast the return of malloc.
ok.
> Why not just declare a static array?
I tried with a static array but it doesn't give the expected result (a quick
test with onenand info command returns an empty mtd name), so I used a
pointer.
> It'd be better to use snprintf, even if you're pretty sure it won't
> overflow.
I tried it too :) U-Boot doesn't have snprintf or asprintf or I missed
something.
Do I need to re-submit the patch only for cast ?
cheers,
Fathi
next reply other threads:[~2008-08-06 16:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 16:32 Fathi BOUDRA [this message]
2008-08-06 16:37 ` [U-Boot-Users] [PATCH] Fill in remaining MTD driver data for OneNAND (take #2) Scott Wood
-- strict thread matches above, loose matches on Subject: below --
2008-08-06 8:06 Fathi BOUDRA
2008-08-06 16:09 ` Scott Wood
2008-08-06 16:18 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808061832.04718.fabo@debian.org \
--to=fabo@debian.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.