From: Paul Moore <paul.moore@hp.com>
To: Vesa-Matti Kari <vmkari@cc.helsinki.fi>
Cc: sds@tycho.nsa.gov, jmorris@namei.org, eparis@parisplace.org,
selinux@tycho.nsa.gov
Subject: Re: [PATCH] selinux: Unify for- and while-loop style
Date: Thu, 7 Aug 2008 08:15:24 -0400 [thread overview]
Message-ID: <200808070815.25086.paul.moore@hp.com> (raw)
In-Reply-To: <200808070036.m770ajof012753@ruuvi.it.helsinki.fi>
On Wednesday 06 August 2008 8:18:20 pm Vesa-Matti Kari wrote:
> Replace "thing != NULL" comparisons with just "thing" to make
> the code look more uniform (mixed styles were used even in the
> same source file).
>
> Signed-off-by: Vesa-Matti Kari <vmkari@cc.helsinki.fi>
> ---
> security/selinux/ss/avtab.c | 2 +-
> security/selinux/ss/conditional.c | 16 ++++++++--------
> security/selinux/ss/ebitmap.c | 4 ++--
> security/selinux/ss/hashtab.c | 6 +++---
> security/selinux/ss/services.c | 8 ++++----
> security/selinux/ss/sidtab.c | 12 ++++++------
In my opinion this suffers from the same problems as the variable
renaming patches. I vote "no".
--
paul moore
linux @ hp
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2008-08-07 12:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 0:18 [PATCH] selinux: Unify for- and while-loop style Vesa-Matti Kari
2008-08-07 12:15 ` Paul Moore [this message]
2008-08-08 10:45 ` Vesa-Matti J Kari
2008-08-08 14:07 ` Paul Moore
2008-08-14 16:45 ` Stephen Smalley
2008-08-14 16:42 ` Stephen Smalley
2008-08-14 23:05 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808070815.25086.paul.moore@hp.com \
--to=paul.moore@hp.com \
--cc=eparis@parisplace.org \
--cc=jmorris@namei.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=vmkari@cc.helsinki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.