From: Steve Grubb <sgrubb@redhat.com>
To: Zhang Xiliang <zhangxiliang@cn.fujitsu.com>
Cc: Linux Audit <linux-audit@redhat.com>
Subject: Re: [PATCH 1/2] Fix the bug for missing field name before operator
Date: Thu, 7 Aug 2008 16:52:51 -0400 [thread overview]
Message-ID: <200808071652.51674.sgrubb@redhat.com> (raw)
In-Reply-To: <489ACF21.8080707@cn.fujitsu.com>
On Thursday 07 August 2008 06:32:01 Zhang Xiliang wrote:
> I think the way "f == v" can't make sure that they didn't type -F =10.
> After "v = strstr(pair, "=")" and v++. The v will not equal to f.
>
> It is checked by "audit_name_to_field()", but not "f == v".
> Because before v++, the "*v" is set to 0. we can use "*f == 0" to check out
> the case. The patch is for it.
Applied. Thanks for the patch !
-Steve
prev parent reply other threads:[~2008-08-07 20:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-07 10:32 [PATCH 1/2] Fix the bug for missing field name before operator Zhang Xiliang
2008-08-07 20:52 ` Steve Grubb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808071652.51674.sgrubb@redhat.com \
--to=sgrubb@redhat.com \
--cc=linux-audit@redhat.com \
--cc=zhangxiliang@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.