From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KRAqB-0003ny-Uj for mharc-grub-devel@gnu.org; Thu, 07 Aug 2008 15:08:03 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KRAq9-0003l6-P2 for grub-devel@gnu.org; Thu, 07 Aug 2008 15:08:01 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KRAq8-0003j2-01 for grub-devel@gnu.org; Thu, 07 Aug 2008 15:08:01 -0400 Received: from [199.232.76.173] (port=60665 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KRAq7-0003ii-Pf for grub-devel@gnu.org; Thu, 07 Aug 2008 15:07:59 -0400 Received: from aybabtu.com ([69.60.117.155]:45194) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KRAq7-0008Nc-MN for grub-devel@gnu.org; Thu, 07 Aug 2008 15:07:59 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KRAib-0004qH-3I for grub-devel@gnu.org; Thu, 07 Aug 2008 21:00:13 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KRAp2-0001Am-1U for grub-devel@gnu.org; Thu, 07 Aug 2008 21:06:52 +0200 Date: Thu, 7 Aug 2008 21:06:52 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080807190652.GA4413@thorin> References: <20080806113530.GA2718@thorin> <20080806195736.GA30755@thorin> <20080807102150.GB23424@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] New command checktime X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Aug 2008 19:08:02 -0000 On Fri, Aug 08, 2008 at 01:52:07AM +0800, Bean wrote: > date 10-05-13-15 > Oct 5, 13:15 Nice. Btw this will be real fun for translators when we have gettext support ;-) > + if (n < 0) > + return grub_error (GRUB_ERR_BAD_ARGUMENT, "invalid date"); > + > + switch (pos) > + { > + case 0: > + if ((n < 1) || (n > 12)) > + return grub_error (GRUB_ERR_BAD_ARGUMENT, "invalid date"); > + > + mask |= GRUB_DATETIME_SET_MONTH; > + datetime.month = n; > + break; > + > + case 1: > + if ((n < 1) || (n > 31)) > + return grub_error (GRUB_ERR_BAD_ARGUMENT, "invalid date"); > + > + mask |= GRUB_DATETIME_SET_DAY; > + datetime.day = n; > + break; > + > + case 2: > + if (n > 23) > + return grub_error (GRUB_ERR_BAD_ARGUMENT, "invalid date"); > + > + mask |= GRUB_DATETIME_SET_HOUR; > + datetime.hour = n; > + break; > + > + case 3: > + if (n > 59) > + return grub_error (GRUB_ERR_BAD_ARGUMENT, "invalid date"); > + > + mask |= GRUB_DATETIME_SET_MINUTE; > + datetime.minute = n; > + break; > + > + case 4: > + if (n > 99) > + return grub_error (GRUB_ERR_BAD_ARGUMENT, "invalid date"); Since those grub_error calls are always the same, I think it'd be a good idea to group them together in a "fail:" section to save space. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."