All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steve Grubb <sgrubb@redhat.com>
To: Cai Xianchao <caixianchao@cn.fujitsu.com>
Cc: Linux Audit <linux-audit@redhat.com>
Subject: Re: [PATCH] Error message is not appropriate when try to set gid to negative
Date: Fri, 8 Aug 2008 09:42:46 -0400	[thread overview]
Message-ID: <200808080942.47414.sgrubb@redhat.com> (raw)
In-Reply-To: <489BC58C.2060208@cn.fujitsu.com>

On Friday 08 August 2008 00:03:24 Cai Xianchao wrote:
> The error message is not appropriate when I try to set gid to
> negative. the value of "Unknown group:" should be the gid rather
> than "gid". There is the same problem in uids.

OK, I tried to apply the patch and got:

patching file deprecated.c
patch: **** malformed patch at line 6: const char *pair, int flags)

I eventually did the edits by hand since they were simple. Watch the word 
wrapping.  :)

Thanks for the patch !

-Steve

      reply	other threads:[~2008-08-08 13:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08  4:03 [PATCH] Error message is not appropriate when try to set gid to negative Cai Xianchao
2008-08-08 13:42 ` Steve Grubb [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808080942.47414.sgrubb@redhat.com \
    --to=sgrubb@redhat.com \
    --cc=caixianchao@cn.fujitsu.com \
    --cc=linux-audit@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.