From: Andrew Morton <akpm@linux-foundation.org>
To: Claudio Nieder <private@claudio.ch>
Cc: rpurdie@rpsys.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Backlight driver for Tabletkiosk Sahara TouchIT-213 Tablet PC
Date: Mon, 11 Aug 2008 13:49:40 -0700 [thread overview]
Message-ID: <20080811134940.b3bcde83.akpm@linux-foundation.org> (raw)
In-Reply-To: <488E25F4.4020405@claudio.ch>
On Mon, 28 Jul 2008 22:03:00 +0200
Claudio Nieder <private@claudio.ch> wrote:
>
> ...
>
> +void kb3886_bl_set_intensity(int intensity)
> +{
> + mutex_lock(&bl_mutex);
> + intensity = intensity&0xff;
> + outb(KB3886_ADC_DAC_PWM, KB3886_PARENT);
> + mdelay(10);
> + outb(KB3886_PWM0_WRITE, KB3886_IO);
> + mdelay(10);
> + outb(intensity, KB3886_IO);
> + mutex_unlock(&bl_mutex);
> +}
I believe the mdelay()s could be converted to the preferable msleep()?
> ...
>
next prev parent reply other threads:[~2008-08-11 20:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <488E0D2A.1000005@claudio.ch>
[not found] ` <1217270428.6059.39.camel@dax.rpnet.com>
2008-07-28 20:03 ` [PATCH] Backlight driver for Tabletkiosk Sahara TouchIT-213 Tablet PC Claudio Nieder
2008-08-11 20:49 ` Andrew Morton [this message]
2008-08-12 17:38 ` Claudio Nieder
2008-08-19 6:32 ` Andrey Panin
2008-08-19 23:00 ` Claudio Nieder
2008-08-20 5:55 ` Andrey Panin
2008-08-20 20:01 ` Claudio Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080811134940.b3bcde83.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=private@claudio.ch \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.