From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KSX4k-0001vY-Cn
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 09:04:42 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KSX4i-0001vI-MR
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 09:04:41 -0400
Received: from [199.232.76.173] (port=44678 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KSX4i-0001vF-EZ
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 09:04:40 -0400
Received: from mail.codesourcery.com ([65.74.133.4]:50985)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1KSX4h-0005Ug-NF
	for qemu-devel@nongnu.org; Mon, 11 Aug 2008 09:04:40 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] [x86] Clean up vendor identification
Date: Mon, 11 Aug 2008 14:04:32 +0100
References: <48A01658.6030308@suse.de> <1218455786.3871.2.camel@frecb07144>
In-Reply-To: <1218455786.3871.2.camel@frecb07144>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200808111404.33988.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <Laurent.Vivier@bull.net>, Alexander Graf <agraf@suse.de>

> > +#define CPUID_VENDOR_AMD_3   0x444d4163 /* "cAMD" */
>
> if you add "-Wno-multichar" in C flags, you can use:
>
> #define CPUID_VENDOR_INTEL_1 'Genu'

I recommend against doing this. The meaning of multi-character constants is 
implementation defined, and the gcc definition has changed at least once.

Paul