All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <felipe.balbi@nokia.com>
Cc: Jean Delvare <khali@linux-fr.org>,
	David Brownell <david-b@pacbell.net>,
	linux-arm-kernel@lists.arm.linux.org.uk,
	linux-omap@vger.kernel.org, Deepak Saxena <dsaxena@plexity.net>,
	carlos.aguiar@indt.org.br
Subject: [PATCH] Fix isp1301_omap compile (Re: testers wanted: isp1301_omap conversion to new-style i2c driver)
Date: Mon, 11 Aug 2008 18:24:11 +0300	[thread overview]
Message-ID: <20080811152410.GN25784@atomide.com> (raw)
In-Reply-To: <20080808094853.GW30719@gandalf.research.nokia.com>

[-- Attachment #1: Type: text/plain, Size: 639 bytes --]

Hi,

* Felipe Balbi <felipe.balbi@nokia.com> [080808 12:49]:
> On Fri, Aug 08, 2008 at 12:45:52PM +0300, Tony Lindgren wrote:
> > Yeah, I will add it to linux-omap for testing for sure. This should be
> > easy to test though, it either works or does not.. But we need to find
> > somebody to boot it and connect USB cable to it :)
> 
> Hi Carlos,
> 
> could you test it for us on H2 ??
> 
> Do you guys still have H2 boards there ?

Also H4 needs to be tested.

I've synced linux-omap tree with mainline tree at v2.6.27-rc2, and
applied Felipe's and Jean's patches. Following patch should be merged
to them to fix compile.

Regards,

Tony

[-- Attachment #2: i2c-isp1301-omap-fix.patch --]
[-- Type: text/x-diff, Size: 1030 bytes --]

>From d12a00e66e97f2e808217eb3e9c9e88d4a281530 Mon Sep 17 00:00:00 2001
From: Tony Lindgren <tony@atomide.com>
Date: Mon, 11 Aug 2008 17:45:32 +0300
Subject: [PATCH] I2C: Fix isp1301_omap.c compile

Fix isp1301_omap.c compile

Signed-off-by: Tony Lindgren <tony@atomide.com>

diff --git a/drivers/i2c/chips/isp1301_omap.c b/drivers/i2c/chips/isp1301_omap.c
index c250668..71a0a2e 100644
--- a/drivers/i2c/chips/isp1301_omap.c
+++ b/drivers/i2c/chips/isp1301_omap.c
@@ -1210,7 +1210,7 @@ static void isp1301_release(struct device *dev)
 {
 	struct isp1301	*isp;
 
-	isp = device_get_drvdata(dev);
+	isp = dev_get_drvdata(dev);
 
 	/* ugly -- i2c hijacks our memory hook to wait_for_completion() */
 	if (isp->i2c_release)
@@ -1564,7 +1564,7 @@ static int __init isp1301_probe(struct i2c_client *i2c)
 	if (machine_is_omap_h2()) {
 		/* full speed signaling by default */
 		isp1301_set_bits(isp, ISP1301_MODE_CONTROL_1,
-			MC1_SPEED_REG);
+			MC1_SPEED);
 		isp1301_set_bits(isp, ISP1301_MODE_CONTROL_2,
 			MC2_SPD_SUSP_CTRL);
 

  reply	other threads:[~2008-08-11 15:25 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-17 18:43 testers wanted: isp1301_omap conversion to new-style i2c driver Jean Delvare
2008-08-07 16:34 ` Jean Delvare
2008-08-07 23:51   ` David Brownell
2008-08-08  7:29     ` Tony Lindgren
2008-08-08  9:17       ` Jean Delvare
2008-08-08  9:39         ` Felipe Balbi
2008-08-08  9:45         ` Tony Lindgren
2008-08-08  9:48           ` Felipe Balbi
2008-08-11 15:24             ` Tony Lindgren [this message]
2008-08-11 16:23               ` [PATCH] Fix isp1301_omap compile (Re: testers wanted: isp1301_omap conversion to new-style i2c driver) Jean Delvare
2008-08-11 18:40                 ` David Brownell
2008-08-12  9:29                   ` Tony Lindgren
2008-08-12  9:51                     ` Jean Delvare
2008-08-18 12:21                       ` Tony Lindgren
2008-08-18 12:34                         ` Jean Delvare
2008-08-18 12:42                           ` Tony Lindgren
2008-08-12 10:17                     ` David Brownell
2008-08-11 18:46               ` David Brownell
2008-09-10 22:31             ` testers wanted: isp1301_omap conversion to new-style i2c driver Tony Lindgren
2008-09-11  7:15               ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080811152410.GN25784@atomide.com \
    --to=tony@atomide.com \
    --cc=carlos.aguiar@indt.org.br \
    --cc=david-b@pacbell.net \
    --cc=dsaxena@plexity.net \
    --cc=felipe.balbi@nokia.com \
    --cc=khali@linux-fr.org \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.