All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Baudis <pasky@suse.cz>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: Reece Dunn <msclrhd@googlemail.com>,
	Francis Moreau <francis.moro@gmail.com>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	git@vger.kernel.org
Subject: Re: git-bisect: weird usage of read(1)
Date: Mon, 11 Aug 2008 19:05:15 +0200	[thread overview]
Message-ID: <20080811170515.GD10151@machine.or.cz> (raw)
In-Reply-To: <48A0705B.3030107@lsrfire.ath.cx>

On Mon, Aug 11, 2008 at 07:01:15PM +0200, René Scharfe wrote:
> Petr Baudis schrieb:
> > On Mon, Aug 11, 2008 at 04:59:32PM +0100, Reece Dunn wrote:
> >>>> On Mon, 11 Aug 2008, Francis Moreau wrote:
> >>>>>               case "$(read yesno)" in [Nn]*) exit 1 ;; esac
> >> does not work as expected. Replacing this with
> >>
> >>                case "$(read yesno; echo $yesno)" in [Nn]*) exit 1 ;; esac
> >>
> >> would work as intended, as Mikael has pointed out.
> > 
> >   Wouldn't it be more elegant to
> > 
> > 	case "$(head -n 1)" in [Nn]*) exit 1 ;; esac
> 
> Only if head is a built-in, otherwise you fork needlessly.  Not that
> this is a performance critical part, but I wouldn't call it "elegant".

Ok, exec head -n 1. ;) And yes, I know... I guess I've just spent too
much time perl-golfing lately.

> What's wrong with the following variant, already used a few lines up in
> the file?
> 
> 	read yesno
> 	case "$yesno" in [Nn]*) exit 1 ;; esac

Nothing wrong with this one, of course.

-- 
				Petr "Pasky" Baudis
The next generation of interesting software will be done
on the Macintosh, not the IBM PC.  -- Bill Gates

  reply	other threads:[~2008-08-11 17:06 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-11 13:57 git-bisect: weird usage of read(1) Francis Moreau
2008-08-11 14:15 ` Johannes Schindelin
2008-08-11 14:16   ` Mikael Magnusson
2008-08-11 14:18   ` Francis Moreau
2008-08-11 15:59     ` Reece Dunn
2008-08-11 16:23       ` Francis Moreau
2008-08-11 16:26         ` Reece Dunn
2008-08-11 16:29           ` Francis Moreau
2008-08-11 16:49       ` Petr Baudis
2008-08-11 17:01         ` René Scharfe
2008-08-11 17:05           ` Petr Baudis [this message]
2008-08-11 18:59           ` Junio C Hamano
2008-08-11 19:47             ` Francis Moreau
2008-08-11 16:18 ` René Scharfe
2008-08-11 17:38   ` Francis Moreau
  -- strict thread matches above, loose matches on Subject: below --
2008-08-11 14:00 Francis Moreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080811170515.GD10151@machine.or.cz \
    --to=pasky@suse.cz \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=francis.moro@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=msclrhd@googlemail.com \
    --cc=rene.scharfe@lsrfire.ath.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.