From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KSetS-00017B-EB for mharc-grub-devel@gnu.org; Mon, 11 Aug 2008 17:25:34 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KSetQ-00013M-IN for grub-devel@gnu.org; Mon, 11 Aug 2008 17:25:32 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KSetO-0000yE-6F for grub-devel@gnu.org; Mon, 11 Aug 2008 17:25:31 -0400 Received: from [199.232.76.173] (port=53016 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KSetO-0000xy-1z for grub-devel@gnu.org; Mon, 11 Aug 2008 17:25:30 -0400 Received: from aybabtu.com ([69.60.117.155]:40354) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KSetN-0000vG-HA for grub-devel@gnu.org; Mon, 11 Aug 2008 17:25:29 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KSelR-0007Lh-Hm for grub-devel@gnu.org; Mon, 11 Aug 2008 23:17:18 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KSesE-0002IL-C7 for grub-devel@gnu.org; Mon, 11 Aug 2008 23:24:18 +0200 Date: Mon, 11 Aug 2008 23:24:18 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080811212418.GC6883@thorin> References: <20080811152238.GA23380@thorin> <48A05D25.6040209@nic.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <48A05D25.6040209@nic.fi> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] decouple mmap parsing by using grub_available_iterate() X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Aug 2008 21:25:32 -0000 On Mon, Aug 11, 2008 at 06:39:17PM +0300, Vesa Jääskeläinen wrote: > Robert Millan wrote: > >Hi, > > > >This patch decouples memory map parsing into a separate > >grub_available_iterate() > >function, for i386-pc and i386-coreboot. It is mostly intended as a > >cleanup. > >Makes the code more modular so that, for example, the multiboot loader can > >construct a memory map without having specific knowledge of the platform, > >allows to recombine various init.c & mmap.c in different ways, etc. > > Why not use grub_mmap prefix ? You mean like grub_mmap_iterate ? Seems fine (since the change is trivial, I'll skip sending a new patch). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."