From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KSf1Y-0006Y5-50 for mharc-grub-devel@gnu.org; Mon, 11 Aug 2008 17:33:56 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KSf1W-0006Ve-Na for grub-devel@gnu.org; Mon, 11 Aug 2008 17:33:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KSf1V-0006T6-39 for grub-devel@gnu.org; Mon, 11 Aug 2008 17:33:54 -0400 Received: from [199.232.76.173] (port=35601 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KSf1U-0006T0-S0 for grub-devel@gnu.org; Mon, 11 Aug 2008 17:33:52 -0400 Received: from aybabtu.com ([69.60.117.155]:52377) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KSf1U-0002Nr-HN for grub-devel@gnu.org; Mon, 11 Aug 2008 17:33:52 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KSetX-0007MI-U3 for grub-devel@gnu.org; Mon, 11 Aug 2008 23:25:40 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KSf0K-0002MU-Kf for grub-devel@gnu.org; Mon, 11 Aug 2008 23:32:40 +0200 Date: Mon, 11 Aug 2008 23:32:40 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080811213240.GF6883@thorin> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Idea: use menu hook to implement the savedefault command X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Aug 2008 21:33:55 -0000 On Tue, Aug 12, 2008 at 05:03:10AM +0800, Bean wrote: > Hi, > > Now it's possible to implement savedefault with load_env and save_env, > but the problem is we need to add it to every menuitem, it's tedious > process, and new item don't get it automatically. After discussing this on IRC, I just thought of another alternative. We could add a pair of functions to update-grub_lib, like: begin_menuentry () { title=$1 echo "menuentry \"$title\" {" echo "do some env-edit magic" } end_menuentry () { echo "}" } then have each of the /etc/grub.d modules that add menuentries use these functions instead of creating the menuentry directly. As a side-effect benefit, the /etc/grub.d modules become a bit more readable. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."