From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KSfZ9-0001Vt-V4 for mharc-grub-devel@gnu.org; Mon, 11 Aug 2008 18:08:39 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KSfZ8-0001S2-0H for grub-devel@gnu.org; Mon, 11 Aug 2008 18:08:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KSfZ6-0001OC-AV for grub-devel@gnu.org; Mon, 11 Aug 2008 18:08:37 -0400 Received: from [199.232.76.173] (port=37482 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KSfZ6-0001O3-60 for grub-devel@gnu.org; Mon, 11 Aug 2008 18:08:36 -0400 Received: from aybabtu.com ([69.60.117.155]:51453) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KSfZ5-00078c-S5 for grub-devel@gnu.org; Mon, 11 Aug 2008 18:08:36 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KSfR9-0007Nx-IH for grub-devel@gnu.org; Tue, 12 Aug 2008 00:00:24 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KSfXv-0005pF-HJ for grub-devel@gnu.org; Tue, 12 Aug 2008 00:07:23 +0200 Date: Tue, 12 Aug 2008 00:07:23 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080811220723.GA22204@thorin> References: <20080811152238.GA23380@thorin> <48A05D25.6040209@nic.fi> <20080811212418.GC6883@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20080811212418.GC6883@thorin> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] decouple mmap parsing by using grub_available_iterate() X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Aug 2008 22:08:38 -0000 On Mon, Aug 11, 2008 at 11:24:18PM +0200, Robert Millan wrote: > On Mon, Aug 11, 2008 at 06:39:17PM +0300, Vesa Jääskeläinen wrote: > > Robert Millan wrote: > > >Hi, > > > > > >This patch decouples memory map parsing into a separate > > >grub_available_iterate() > > >function, for i386-pc and i386-coreboot. It is mostly intended as a > > >cleanup. > > >Makes the code more modular so that, for example, the multiboot loader can > > >construct a memory map without having specific knowledge of the platform, > > >allows to recombine various init.c & mmap.c in different ways, etc. > > > > Why not use grub_mmap prefix ? > > You mean like grub_mmap_iterate ? Seems fine (since the change is trivial, > I'll skip sending a new patch). Now that I think, grub_mmap_iterate() would be misleading, as we're only iterating through the parts of mmap that are marked as available, not through the whole thing. How about grub_mmap_available_iterate? But this reminds me; with this interface, it's not possible to gather information about regions other than the ones that are marked as available. However, AFAICS, there's no purpose for marking a region as reserved, since the OS is only going to use regions marked as available anyway. Therefore, if we implement support for Multiboot mmaps in our loader (as defined in the spec), we wouldn't be able to include non-available regions in our map. Does anyone see a problem in this? If so, then I think we'd need a function that can for example handle a third argument, for example `type', for this purpose. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."