From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Phillips Subject: Re: [PATCH RFC] dm snapshot: shared exception store Date: Tue, 12 Aug 2008 05:56:57 -0700 Message-ID: <200808120556.57314.phillips@phunq.net> References: <20080804171242V.fujita.tomonori@lab.ntt.co.jp> Reply-To: device-mapper development Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20080804171242V.fujita.tomonori@lab.ntt.co.jp> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: dm-devel@redhat.com Cc: agk@redhat.com List-Id: dm-devel.ids Hi tomonori, An impressive patch. You just want to use getblk for alloc_chunk_buffer, not vmalloc. That is what the buffer cache is for, and that is why I emulated it in userspace. More comments later. Regards, Daniel