From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 1/4] generic support for 64bit inodes in NFS filehandles Date: Tue, 12 Aug 2008 18:31:54 +1000 Message-ID: <20080812083154.GQ6119@disturbed> References: <20080811134848.GC21264@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org To: Christoph Hellwig Return-path: Received: from ipmail05.adl2.internode.on.net ([203.16.214.145]:12166 "EHLO ipmail05.adl2.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751835AbYHLIcI (ORCPT ); Tue, 12 Aug 2008 04:32:08 -0400 Content-Disposition: inline In-Reply-To: <20080811134848.GC21264@lst.de> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Aug 11, 2008 at 03:48:48PM +0200, Christoph Hellwig wrote: > Move XFS's support for 64bit inodes in NFS filehandles to libfs. In > detail: > > - add the FILEID_INO64_FLAG and thei64 case in struct fid to > exportfs.h > - deal with the 64bit inode cases in generic_fh_to_dentry and > generic_fh_to_parent by adding them to the switch case table > and rewriting the min filehandle size checks based on a readable > helper > - move export_encode_fh to libfs as generic_encode_fh32 and rewrite > it to be a similar style as the other exportfs functions in libfs > - add a new generic_encode_fh64 which is identical to > generic_encode_fh32 except for dealing with 64bit inode filehandles > > XFS is switched over to the new code, switching over other filesystems > like ext4 is left to their maintainers but should be rather trivial by > looking at fs/xfs/linux-2.6/xfs_export.c The XFS->generic conversion looks OK to me.... Cheers, Dave. -- Dave Chinner david@fromorbit.com