From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KSpdD-0006Ka-UA for mharc-grub-devel@gnu.org; Tue, 12 Aug 2008 04:53:31 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KSpdB-0006I0-Lf for grub-devel@gnu.org; Tue, 12 Aug 2008 04:53:29 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KSpd9-0006FU-IK for grub-devel@gnu.org; Tue, 12 Aug 2008 04:53:28 -0400 Received: from [199.232.76.173] (port=33720 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KSpd8-0006F2-W1 for grub-devel@gnu.org; Tue, 12 Aug 2008 04:53:27 -0400 Received: from aybabtu.com ([69.60.117.155]:58964) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KSpd8-0006gr-Tm for grub-devel@gnu.org; Tue, 12 Aug 2008 04:53:27 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KSpV9-00013b-0t for grub-devel@gnu.org; Tue, 12 Aug 2008 10:45:11 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KSpbx-000083-Nm for grub-devel@gnu.org; Tue, 12 Aug 2008 10:52:13 +0200 Date: Tue, 12 Aug 2008 10:52:13 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080812085213.GA381@thorin> References: <20080811213240.GF6883@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: Idea: use menu hook to implement the savedefault command X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Aug 2008 08:53:30 -0000 On Tue, Aug 12, 2008 at 09:27:42AM +0800, Bean wrote: > On Tue, Aug 12, 2008 at 5:32 AM, Robert Millan wrote: > > On Tue, Aug 12, 2008 at 05:03:10AM +0800, Bean wrote: > >> Hi, > >> > >> Now it's possible to implement savedefault with load_env and save_env, > >> but the problem is we need to add it to every menuitem, it's tedious > >> process, and new item don't get it automatically. > > > > After discussing this on IRC, I just thought of another alternative. We > > could add a pair of functions to update-grub_lib, like: > > > > begin_menuentry () > > { > > title=$1 > > echo "menuentry \"$title\" {" > > echo "do some env-edit magic" > > } > > > > end_menuentry () > > { > > echo "}" > > } > > > > then have each of the /etc/grub.d modules that add menuentries use these > > functions instead of creating the menuentry directly. > > > > As a side-effect benefit, the /etc/grub.d modules become a bit more > > readable. > > Hi, > > Oh right, if you can do it in update-grub, it's probably better to do > it there. Ok, I'll see about that. > The above post also contain some idea about the > implementation of password command, perhaps I post a seperate post for > it. Notice there's already an implementation of a lock command: http://www.mail-archive.com/grub-devel@gnu.org/msg05350.html which, I think, even without password it would satisfy most of the users who want lock/password. I recommend you read that thread before venturing into implement it (Okuji didn't like my initial proposal, and I run out of time to find/implement another approach). -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."