From: Samuel Thibault <samuel.thibault@eu.citrix.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] fix serial IIR read [Was: SVN Rev 4994 (now) Won't install Windows XP]
Date: Tue, 12 Aug 2008 12:11:15 +0100 [thread overview]
Message-ID: <20080812111115.GF4646@implementation.uk.xensource.com> (raw)
Brad Campbell, le Tue 12 Aug 2008 11:02:39 +0400, a écrit :
> qemu -hda xptest.img -cdrom XP-corp-sp2.iso -boot d -m 256 -no-kqemu
> -no-reboot -no-acpi
>
> It just hangs at "Setup is starting Windows".
The patch below fixes it for me.
Samuel
serial: Always update iir, even when ier is empty.
Signed-off-by: Samuel Thibault <samuel.thibault@eu.citrix.com>
Index: hw/serial.c
===================================================================
--- hw/serial.c (révision 4994)
+++ hw/serial.c (copie de travail)
@@ -189,11 +189,6 @@
{
uint8_t tmp_iir = UART_IIR_NO_INT;
- if (!s->ier) {
- qemu_irq_lower(s->irq);
- return;
- }
-
if ((s->ier & UART_IER_RLSI) && (s->lsr & UART_LSR_INT_ANY)) {
tmp_iir = UART_IIR_RLSI;
} else if (s->timeout_ipending) {
next reply other threads:[~2008-08-12 11:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 11:11 Samuel Thibault [this message]
2008-08-12 11:34 ` [Qemu-devel] [PATCH] fix serial IIR read [Was: SVN Rev 4994 (now) Won't install Windows XP] Stefano Stabellini
2008-08-12 12:39 ` Jason Wessel
2008-08-12 11:35 ` Brad Campbell
2008-08-12 13:22 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080812111115.GF4646@implementation.uk.xensource.com \
--to=samuel.thibault@eu.citrix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.