From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1KSu0L-00031C-6L
	for mharc-grub-devel@gnu.org; Tue, 12 Aug 2008 09:33:41 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KSu0J-00030z-Tp
	for grub-devel@gnu.org; Tue, 12 Aug 2008 09:33:40 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KSu0I-000309-3g
	for grub-devel@gnu.org; Tue, 12 Aug 2008 09:33:39 -0400
Received: from [199.232.76.173] (port=38487 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KSu0H-0002zv-UE
	for grub-devel@gnu.org; Tue, 12 Aug 2008 09:33:37 -0400
Received: from aybabtu.com ([69.60.117.155]:52973)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <rmh@aybabtu.com>) id 1KSu0H-0004gV-V0
	for grub-devel@gnu.org; Tue, 12 Aug 2008 09:33:38 -0400
Received: from [192.168.10.10] (helo=thorin)
	by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.69) (envelope-from <rmh@aybabtu.com>) id 1KStsH-0001mh-Cn
	for grub-devel@gnu.org; Tue, 12 Aug 2008 15:25:21 +0200
Received: from rmh by thorin with local (Exim 4.63)
	(envelope-from <rmh@aybabtu.com>) id 1KStz5-0003hg-Q9
	for grub-devel@gnu.org; Tue, 12 Aug 2008 15:32:23 +0200
Date: Tue, 12 Aug 2008 15:32:23 +0200
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Message-ID: <20080812133223.GB13942@thorin>
References: <ca0f59980808100452u505cdc67x9a377929d96f3894@mail.gmail.com>
	<20080810142913.GB27953@thorin>
	<ca0f59980808100745i222f8986g1108abf770854374@mail.gmail.com>
	<ca0f59980808100849i5687027dnb108ec36e267dd0c@mail.gmail.com>
	<ca0f59980808111145m770f5eafv1eb316944ac1c645@mail.gmail.com>
	<ca0f59980808111313r39eb54dx4c85071c751840ee@mail.gmail.com>
	<ca0f59980808111324u1932c3b5y533b77381d331463@mail.gmail.com>
	<20080811203024.GA6883@thorin>
	<ca0f59980808120449s61abd11iefb197cd3b1672d5@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <ca0f59980808120449s61abd11iefb197cd3b1672d5@mail.gmail.com>
Organization: free as in freedom
X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird!
	www.mozilla.com/thunderbird
X-Debbugs-No-Ack: true
User-Agent: Mutt/1.5.13 (2006-08-11)
X-detected-kernel: by monty-python.gnu.org: Genre and OS details not
	recognized.
Subject: Re: [PATCH] Split of raid scan code
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Tue, 12 Aug 2008 13:33:40 -0000

On Tue, Aug 12, 2008 at 07:49:19PM +0800, Bean wrote:
> 
> Ok, I make some adjustment, now grub-install & update-grub works for
> raid device.
> [...]
> --- a/util/grub-probe.c
> +++ b/util/grub-probe.c
> @@ -142,7 +142,7 @@ probe (const char *path, char *device_name)
>  	  abstraction_name = "lvm";
>  	  break;
>  	case GRUB_DEV_ABSTRACTION_RAID:
> -	  abstraction_name = "raid";
> +	  abstraction_name = "raid mdraid";

Should be fine, I think.

> -	    buf += read_size;
> +	    buf += read_size << GRUB_DISK_SECTOR_BITS;

Felix told me this fixes a problem in current RAID code;  when you check
your code in, please consider including this bugfix in a separate commit.
This makes it easier to track things.

Thanks!

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."