From: Muli Ben-Yehuda <muli@il.ibm.com>
To: Joerg Roedel <joerg.roedel@amd.com>
Cc: mingo@redhat.com, tglx@linutronix.de, hpa@zytor.com,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org,
andi@firstfloor.org
Subject: Re: [PATCH 0/7] x86 dma_*_coherent rework patchset
Date: Tue, 12 Aug 2008 19:06:58 +0300 [thread overview]
Message-ID: <20080812160658.GH30426@il.ibm.com> (raw)
In-Reply-To: <1218554657-16070-1-git-send-email-joerg.roedel@amd.com>
[added Andi to CC]
On Tue, Aug 12, 2008 at 05:24:10PM +0200, Joerg Roedel wrote:
> Hi,
>
> this patchset reworks the dma_*_coherent functions in the DMA layer
> for the x86 architecture. The patch series extends the existing DMA
> backends with missing *coherent callbacks and simplifies the generic
> function to basically only call the registered backend. This allows
> future optimizations in hardware specific IOMMU implementations.
> The code ist tested on AMD64 with AMD IOMMU and GART as well as on
> my old 486 box. It is not yet tested on a Calgary IOMMU system.
Now it is---appears to work fine on a Calgary system.
In general the patchset looks good and is definitely a step in the
right direction. I am a bit concerned about the contortions that the
generic dma_alloc_coherent went through before calling the ops
version---have you verified they are no longer needed?
Cheers,
Muli
--
Workshop on I/O Virtualization (WIOV '08)
Co-located with OSDI '08, Dec 2008, San Diego, CA
http://www.usenix.org/wiov08
next prev parent reply other threads:[~2008-08-12 16:08 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 15:24 [PATCH 0/7] x86 dma_*_coherent rework patchset Joerg Roedel
2008-08-12 15:24 ` [PATCH 1/7] x86: add alloc_coherent dma_ops callback to GART driver Joerg Roedel
2008-08-13 0:45 ` FUJITA Tomonori
2008-08-13 12:46 ` Joerg Roedel
2008-08-13 20:46 ` FUJITA Tomonori
2008-08-12 15:24 ` [PATCH 2/7] x86: add free_coherent " Joerg Roedel
2008-08-13 0:45 ` FUJITA Tomonori
2008-08-13 12:49 ` Joerg Roedel
2008-08-12 15:24 ` [PATCH 3/7] x86: add free_coherent dma_ops callback to Calgary IOMMU driver Joerg Roedel
2008-08-12 16:07 ` Muli Ben-Yehuda
2008-08-12 15:24 ` [PATCH 4/7] x86: add alloc_coherent dma_ops callback to NOMMU driver Joerg Roedel
2008-08-12 18:24 ` Joerg Roedel
2008-08-12 15:24 ` [PATCH 5/7] x86: add free_coherent " Joerg Roedel
2008-08-12 15:24 ` [PATCH 6/7] x86: cleanup dma_*_coherent functions Joerg Roedel
2008-08-13 0:45 ` FUJITA Tomonori
2008-08-13 12:51 ` Joerg Roedel
2008-08-12 15:24 ` [PATCH 7/7] x86, AMD IOMMU: remove obsolete FIXME comment Joerg Roedel
2008-08-12 16:06 ` Muli Ben-Yehuda [this message]
2008-08-12 16:49 ` [PATCH 0/7] x86 dma_*_coherent rework patchset Joerg Roedel
2008-08-13 0:51 ` FUJITA Tomonori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080812160658.GH30426@il.ibm.com \
--to=muli@il.ibm.com \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=iommu@lists.linux-foundation.org \
--cc=joerg.roedel@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.