From: Paul Walmsley <paul@pwsan.com>
To: linux-omap@vger.kernel.org
Cc: Paul Walmsley <paul@pwsan.com>, felipe.balbi@nokia.com
Subject: [PATCH 1/2] OMAP2 clock: associate clocks with clockdomains at startup
Date: Tue, 12 Aug 2008 15:31:44 -0600 [thread overview]
Message-ID: <20080812213141.24628.45988.stgit@localhost.localdomain> (raw)
In-Reply-To: <20080812212919.24628.82229.stgit@localhost.localdomain>
The OMAP2 clock code was missing code to associate clocks with clockdomains
at registration time; fix this.
Resolves "Unhandled fault: alignment exception (0x001) at 0xc02c1b4e" (address
may vary) panic during clock framework init on OMAP2. The alignment error
was caused by an attempt to dereference a pointer to a string (1-byte aligned)
as if it were a pointer to a structure.
Thanks to Felipe Balbi <felipe.balbi@nokia.com> for originally reporting this
bug.
Signed-off-by: Paul Walmsley <paul@pwsan.com>
---
arch/arm/mach-omap2/clock24xx.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/clock24xx.c b/arch/arm/mach-omap2/clock24xx.c
index 370f4f0..0d9d91f 100644
--- a/arch/arm/mach-omap2/clock24xx.c
+++ b/arch/arm/mach-omap2/clock24xx.c
@@ -567,11 +567,13 @@ int __init omap2_clk_init(void)
if ((*clkp)->flags & CLOCK_IN_OMAP242X && cpu_is_omap2420()) {
clk_register(*clkp);
+ omap2_init_clk_clkdm(*clkp);
continue;
}
if ((*clkp)->flags & CLOCK_IN_OMAP243X && cpu_is_omap2430()) {
clk_register(*clkp);
+ omap2_init_clk_clkdm(*clkp);
continue;
}
}
next prev parent reply other threads:[~2008-08-12 21:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-12 21:31 [PATCH 0/2] OMAP2/3: fix clock/clockdomain bugs Paul Walmsley
2008-08-12 21:31 ` Paul Walmsley [this message]
2008-08-12 21:31 ` [PATCH 2/2] OMAP2/3 clockdomains: autodeps should respect platform flags Paul Walmsley
2008-08-13 7:43 ` [PATCH 0/2] OMAP2/3: fix clock/clockdomain bugs Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080812213141.24628.45988.stgit@localhost.localdomain \
--to=paul@pwsan.com \
--cc=felipe.balbi@nokia.com \
--cc=linux-omap@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.