All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grant Likely <grant.likely@secretlab.ca>
To: David VomLehn <dvomlehn@cisco.com>
Cc: Daniel Walker <dwalker@mvista.com>, linux-embedded@vger.kernel.org
Subject: Re: [PATCH] [RFC] emit-crash-char: Allow diversion of printk output for crash logging
Date: Tue, 12 Aug 2008 20:12:12 -0600	[thread overview]
Message-ID: <20080813021212.GA17587@secretlab.ca> (raw)
In-Reply-To: <48A2394E.8030500@cisco.com>

On Tue, Aug 12, 2008 at 06:30:54PM -0700, David VomLehn wrote:
> Grant Likely wrote:
>
>> I'm not thrilled with this patch.  It seems so much more straight
>> forward in your special case, but it comes at the expense of making
>> the code path more complex in every other case.
>>
>> I would much rather see this be done using the existing console driver
>> interface.  The only possible reason I could see wanting to do things
>> this way is if you don't trust the console code to call your console
>> driver, which I think is a pretty unlikely case.
>
> I'll buy that reasoning.
>
> Regardless of implementation, it seems to me that it could be of use for 
> some other embedded platforms. Any suggestions as to where it should go 
> in the tree? drivers/char? drivers/misc?

Depends on what you're storing to.  Can you send more details about the
specific use case that you will use this interface for?

g.

  reply	other threads:[~2008-08-13  2:12 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08  2:20 [PATCH] [RFC] emit-crash-char: Allow diversion of printk output for crash logging David VomLehn
2008-08-08 15:55 ` Daniel Walker
2008-08-08 16:05   ` Mike Frysinger
2008-08-08 16:17     ` Daniel Walker
2008-08-08 18:09       ` Mike Frysinger
2008-08-08 20:10         ` Daniel Walker
2008-08-08 20:13           ` Mike Frysinger
2008-08-08 20:47             ` Daniel Walker
2008-08-08 21:24               ` [PATCH] [RFC] emit-crash-char: Allow diversion of printkoutput " Haller, John H (John)
2008-08-08 22:01                 ` Daniel Walker
2008-08-11 23:34   ` [PATCH] [RFC] emit-crash-char: Allow diversion of printk output " David VomLehn
2008-08-12 22:39     ` Grant Likely
2008-08-13  1:30       ` David VomLehn
2008-08-13  2:12         ` Grant Likely [this message]
2008-08-13 17:56           ` David VomLehn
2008-08-13 19:02             ` Tim Bird
2008-08-13 20:27               ` David VomLehn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080813021212.GA17587@secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=dvomlehn@cisco.com \
    --cc=dwalker@mvista.com \
    --cc=linux-embedded@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.