From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([66.187.233.31]) by bombadil.infradead.org with esmtp (Exim 4.68 #1 (Red Hat Linux)) id 1KTGGe-0004YZ-HM for kexec@lists.infradead.org; Wed, 13 Aug 2008 13:20:00 +0000 Date: Wed, 13 Aug 2008 09:19:27 -0400 From: Vivek Goyal Subject: Re: [PATCH] kexec jump: fix code size checking Message-ID: <20080813131927.GB3957@redhat.com> References: <1218589475.24951.59.camel@caritas-dev.intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1218589475.24951.59.camel@caritas-dev.intel.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Huang Ying Cc: nigel@nigel.suspend2.net, Kexec Mailing List , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , "Eric W. Biederman" , Pavel Machek , Andrew Morton , Linus Torvalds , mingo@elte.hu On Wed, Aug 13, 2008 at 09:04:35AM +0800, Huang Ying wrote: > Fix building issue when CONFIG_KEXEC=n. Thanks to Vivek Goyal for his > reminding. > > Signed-off-by: Huang Ying > > --- > include/asm-x86/kexec.h | 3 +++ > 1 file changed, 3 insertions(+) > > --- a/include/asm-x86/kexec.h > +++ b/include/asm-x86/kexec.h > @@ -43,6 +43,9 @@ > > #ifdef CONFIG_X86_32 > # define KEXEC_CONTROL_CODE_MAX_SIZE 2048 > +# ifndef CONFIG_KEXEC > +# define kexec_control_code_size 0 > +# endif > #endif > > #ifndef __ASSEMBLY__ I think Andrew already fixed it. Right way is to put code in vmlinux.lds.S under #ifdef CONFIG_KEXEC, than defining the symbol kexec_control_code_size if CONFIG_KEXEC=n Thanks Vivek _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754141AbYHMNUb (ORCPT ); Wed, 13 Aug 2008 09:20:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752616AbYHMNUX (ORCPT ); Wed, 13 Aug 2008 09:20:23 -0400 Received: from mx1.redhat.com ([66.187.233.31]:57591 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752582AbYHMNUW (ORCPT ); Wed, 13 Aug 2008 09:20:22 -0400 Date: Wed, 13 Aug 2008 09:19:27 -0400 From: Vivek Goyal To: Huang Ying Cc: "Eric W. Biederman" , Pavel Machek , nigel@nigel.suspend2.net, "Rafael J. Wysocki" , Andrew Morton , mingo@elte.hu, Linus Torvalds , linux-kernel@vger.kernel.org, Kexec Mailing List Subject: Re: [PATCH] kexec jump: fix code size checking Message-ID: <20080813131927.GB3957@redhat.com> References: <1218589475.24951.59.camel@caritas-dev.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1218589475.24951.59.camel@caritas-dev.intel.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 13, 2008 at 09:04:35AM +0800, Huang Ying wrote: > Fix building issue when CONFIG_KEXEC=n. Thanks to Vivek Goyal for his > reminding. > > Signed-off-by: Huang Ying > > --- > include/asm-x86/kexec.h | 3 +++ > 1 file changed, 3 insertions(+) > > --- a/include/asm-x86/kexec.h > +++ b/include/asm-x86/kexec.h > @@ -43,6 +43,9 @@ > > #ifdef CONFIG_X86_32 > # define KEXEC_CONTROL_CODE_MAX_SIZE 2048 > +# ifndef CONFIG_KEXEC > +# define kexec_control_code_size 0 > +# endif > #endif > > #ifndef __ASSEMBLY__ I think Andrew already fixed it. Right way is to put code in vmlinux.lds.S under #ifdef CONFIG_KEXEC, than defining the symbol kexec_control_code_size if CONFIG_KEXEC=n Thanks Vivek