From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KTIJs-00011T-Oj for mharc-grub-devel@gnu.org; Wed, 13 Aug 2008 11:31:28 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTIJr-0000z6-BO for grub-devel@gnu.org; Wed, 13 Aug 2008 11:31:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTIJm-0000ny-SI for grub-devel@gnu.org; Wed, 13 Aug 2008 11:31:26 -0400 Received: from [199.232.76.173] (port=35593 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTIJm-0000nd-Mh for grub-devel@gnu.org; Wed, 13 Aug 2008 11:31:22 -0400 Received: from 197.red-80-32-81.staticip.rima-tde.net ([80.32.81.197]:54186 helo=mail.pina.cat) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1KTIJm-0006KR-27 for grub-devel@gnu.org; Wed, 13 Aug 2008 11:31:22 -0400 Received: from pinux (142.81.221.87.dynamic.jazztel.es [87.221.81.142]) by mail.pina.cat (Postfix) with ESMTP id A87FB288F30C3 for ; Wed, 13 Aug 2008 17:31:15 +0200 (CEST) Received: by pinux (Postfix, from userid 1000) id 9D2F0EF26; Wed, 13 Aug 2008 17:31:13 +0200 (CEST) Date: Wed, 13 Aug 2008 17:31:13 +0200 From: Carles Pina i Estany To: The development of GRUB 2 Message-ID: <20080813153113.GB6028@pina.cat> References: <20080721180723.GC7501@pina.cat> <20080805120200.GA15143@pina.cat> <8763qfeh54.fsf@xs4all.nl> <20080806183131.GA5815@pina.cat> <87abfh9q5y.fsf@xs4all.nl> <20080813105002.GA23361@thorin> <1218627507.8757.16.camel@localhost> <20080813114428.GA25113@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20080813114428.GA25113@thorin> User-Agent: Mutt/1.5.18 (2008-05-17) Content-Transfer-Encoding: quoted-printable X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) Subject: Re: [PATCH] Home-End keys in menu X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Aug 2008 15:31:27 -0000 Hello, I reply in this message a different things. On Aug/13/2008, Robert Millan wrote: > On Wed, Aug 13, 2008 at 01:38:27PM +0200, Javier Mart=EDn wrote: > > El mi=E9, 13-08-2008 a las 12:50 +0200, Robert Millan escribi=F3: > > > On Wed, Aug 13, 2008 at 12:15:37PM +0200, Marco Gerards wrote: > > > > Hi, > > > >=20 > > > > Carles Pina i Estany writes: > > > >=20 > > > > [...] > > > >=20 > > > > > 2008-08-06 Carles Pina i Estany > > > > > > > > > > * menu/normal.c (run_menu): Add Home and End keys in grub-menu= . > > > >=20 > > > >=20 > > > > This looks fine to me at first sight. Do others have problems wi= th > > > > this? Otherwise it can be committed. > > >=20 > > > Why don't we use PgUp / PgDn instead? That's more intuitive. I think that we should use Home/End and PgUp/PgDn for different things: -Home/End: go straight to the first and last entry (this is done) -PgUp/PgDn: it moves one page (I mean, selected item =3D selected item + number of items) I've implemented only Home/End key (by the moment, we can talk about PgUp/PgDn later please :-) ) > > Users with long menu lists may expect PgUp/PgDn to take them exactly > > _one_ page up or down, not the whole list... I personally think that > > Home/End are more intuitive for this particular UI interaction. >=20 > Uhm you're right. Also, I notice this behaviour is consistent with > `less' (and since I love consistency, I must agree with you!) >=20 > I think the patch is fine in its current state. me too ;-) --=20 Carles Pina i Estany GPG id: 0x17756391 http://pinux.info