From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KTMOS-0003F4-N7 for mharc-grub-devel@gnu.org; Wed, 13 Aug 2008 15:52:28 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTMOR-0003Bw-Ae for grub-devel@gnu.org; Wed, 13 Aug 2008 15:52:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTMOP-00037p-Mm for grub-devel@gnu.org; Wed, 13 Aug 2008 15:52:26 -0400 Received: from [199.232.76.173] (port=55007 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTMOP-00037d-He for grub-devel@gnu.org; Wed, 13 Aug 2008 15:52:25 -0400 Received: from aybabtu.com ([69.60.117.155]:57608) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KTMOO-0002af-Sh for grub-devel@gnu.org; Wed, 13 Aug 2008 15:52:25 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KTMGG-0006RL-4p for grub-devel@gnu.org; Wed, 13 Aug 2008 21:44:00 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KTMNB-0005lq-Uj for grub-devel@gnu.org; Wed, 13 Aug 2008 21:51:09 +0200 Date: Wed, 13 Aug 2008 21:51:09 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080813195109.GA22009@thorin> References: <20080811152238.GA23380@thorin> <48A05D25.6040209@nic.fi> <20080811212418.GC6883@thorin> <20080811220723.GA22204@thorin> <20080812132515.GA13942@thorin> <20080812162915.GA8518@thorin> <20080812223815.GA3141@thorin> <20080812234430.GA12880@thorin> <87skt8245g.fsf@xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87skt8245g.fsf@xs4all.nl> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] decouple mmap parsing and implement Multiboot mmap in the loader X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Aug 2008 19:52:27 -0000 On Wed, Aug 13, 2008 at 07:52:59PM +0200, Marco Gerards wrote: > > #include > > #include > > +#include /* For struct grub_mmap_entry, which is also > > + needed by Multiboot. */ > > Isn't it better to split the header file? This seems like a hack. The definition is part of the Multiboot spec, so it really needs to be present in multiboot.h. We could also define it separately as grub_mmap_entry in multiboot.h and keep the grub_machine_mmap_entry definition in pc/init.h. Then other arches could have their own grub_machine_mmap_entry variant which _does_ differ from grub_mmap_entry (like coreboot). What do you think? > > Index: loader/i386/pc/multiboot.c > > =================================================================== > > --- loader/i386/pc/multiboot.c (revision 1802) > > +++ loader/i386/pc/multiboot.c (working copy) > > @@ -78,14 +78,60 @@ > > grub_free ((void *) mbi->cmdline); > > grub_free (mbi); > > } > > - > > - > > + > > Hm? :-) Some minor janitor work ;-) -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."