All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Hausmann <simon@lst.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Anand Kumria <wildfire@progsoc.org>, git@vger.kernel.org
Subject: Re: [PATCH 00/12] Allow users to access Perforce repositories requiring authentication
Date: Wed, 13 Aug 2008 21:47:41 +0200	[thread overview]
Message-ID: <200808132147.55119.simon@lst.de> (raw)
In-Reply-To: <1218392795-4084-1-git-send-email-wildfire@progsoc.org>

[-- Attachment #1: Type: text/plain, Size: 718 bytes --]

Hi,

On Sunday 10 August 2008 20:26:23 Anand Kumria wrote:
> Hi,
>
> This series of patches refactors a few function calls into git-p4
> so that they all go via the same function to build up the command
> line.
>
> It also then allows users to specify any particular user / password
> required to access their Perforce repository (plus a few other parameters).
>
> I have specifically tested this agains the public Zimbra repository and
> it works for me fine. Any feedback would be welcomed.

Junio, I saw that you queued up this series in pu as ak/p4. I looked through 
the patches and I think they look great. I suggest to include them into master 
after 1.6.0.

Anand, great work :)


Simon

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2008-08-13 19:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-10 18:26 [PATCH 00/12] Allow users to access Perforce repositories requiring authentication Anand Kumria
2008-08-10 18:26 ` [PATCH 01/12] Create a specific version of the read_pipe_lines command for p4 invocations Anand Kumria
2008-08-10 18:26   ` [PATCH 02/12] Utilise the new 'p4_read_pipe_lines' command Anand Kumria
2008-08-10 18:26     ` [PATCH 03/12] Have a command that specifically invokes 'p4' (via system) Anand Kumria
2008-08-10 18:26       ` [PATCH 04/12] Utilise the new 'p4_system' function Anand Kumria
2008-08-10 18:26         ` [PATCH 05/12] Add a single command that will be used to construct the 'p4' command Anand Kumria
2008-08-10 18:26           ` [PATCH 06/12] If we are in verbose mode, output what we are about to run (or return) Anand Kumria
2008-08-10 18:26             ` [PATCH 07/12] Switch to using 'p4_build_cmd' Anand Kumria
2008-08-10 18:26               ` [PATCH 08/12] If the user has configured various parameters, use them Anand Kumria
2008-08-10 18:26                 ` [PATCH 09/12] Consistently use 'git-p4' for the configuration entries Anand Kumria
2008-08-10 18:26                   ` [PATCH 10/12] Move git-p4.syncFromOrigin into a configuration parameters section Anand Kumria
2008-08-10 18:26                     ` [PATCH 11/12] Put some documentation in about the parameters that have been added Anand Kumria
2008-08-10 18:26                       ` [PATCH 12/12] Put in the two other configuration elements found in the source Anand Kumria
2008-08-13 19:47 ` Simon Hausmann [this message]
2008-08-14 17:00 ` [PATCH 00/12] Allow users to access Perforce repositories requiring authentication Tor Arvid Lund
2008-08-14 22:01   ` Anand Kumria

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200808132147.55119.simon@lst.de \
    --to=simon@lst.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=wildfire@progsoc.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.