From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KTOFv-0000HC-6q for mharc-grub-devel@gnu.org; Wed, 13 Aug 2008 17:51:47 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTOFt-0000H0-PF for grub-devel@gnu.org; Wed, 13 Aug 2008 17:51:45 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTOFq-0000GO-0n for grub-devel@gnu.org; Wed, 13 Aug 2008 17:51:45 -0400 Received: from [199.232.76.173] (port=43787 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTOFp-0000GF-Tr for grub-devel@gnu.org; Wed, 13 Aug 2008 17:51:41 -0400 Received: from aybabtu.com ([69.60.117.155]:35367) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KTOFp-0008SK-AP for grub-devel@gnu.org; Wed, 13 Aug 2008 17:51:41 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KTO7b-0006ip-Pt for grub-devel@gnu.org; Wed, 13 Aug 2008 23:43:12 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KTOEZ-0006df-LN for grub-devel@gnu.org; Wed, 13 Aug 2008 23:50:23 +0200 Date: Wed, 13 Aug 2008 23:50:23 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080813215023.GA23069@thorin> References: <1218558487.19045.8.camel@fz.local> <1218558734.19045.10.camel@fz.local> <87fxp9di59.fsf@xs4all.nl> <20080812224041.GB3141@thorin> <1218606980.4008.9.camel@fz.local> <87abfhb60p.fsf@xs4all.nl> <1218659496.25595.7.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1218659496.25595.7.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] kern/err.c + disk/raid.c error handling fixes X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Aug 2008 21:51:46 -0000 On Wed, Aug 13, 2008 at 10:31:36PM +0200, Felix Zielcke wrote: > > Yes this change is no problem, grub-probe now compiles fine > But grub-mkimage not: > > grub_mkimage-util_misc.o: In function `grub_print_error': > /home/fz/grub/grub2.svn/util/misc.c:315: undefined reference to `grub_error_pop' > /home/fz/grub/grub2.svn/util/misc.c:312: undefined reference to `grub_errno' > /home/fz/grub/grub2.svn/util/misc.c:313: undefined reference to `grub_errmsg' > /home/fz/grub/grub2.svn/util/misc.c:315: undefined reference to `grub_error_pop' > collect2: ld returned 1 exit status > make: *** [grub-mkimage] Error 1 This is because util/misc.c adds error handling to grub-mkimage, which wasn't there before. If we can't do this in kern/err.c (although I really think it'd be simpler), adding a new util/err.c that can be used by grub-probe but not grub-mkimage would solve this. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."