From: Don Zickus <dzickus@redhat.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Allow emails with boundaries to work again
Date: Wed, 13 Aug 2008 21:56:04 -0400 [thread overview]
Message-ID: <20080814015604.GD24172@redhat.com> (raw)
In-Reply-To: <7vtzdogyx6.fsf@gitster.siamese.dyndns.org>
On Wed, Aug 13, 2008 at 06:36:53PM -0700, Junio C Hamano wrote:
> Don Zickus <dzickus@redhat.com> writes:
>
> > Recent changes to is_multipart_boundary() caused git-mailinfo to segfault.
> > The reason was after handling the end of the boundary the code tried to look
> > for another boundary. Because the boundary list was empty, dereferencing
> > the pointer to the top of the boundary caused the program to go boom.
> >
> > The fix is to check to see if the list is empty and if so go on its merry
> > way instead of looking for another boundary.
>
> Hmm, at this point !*content_top means that we are at the outermost level
> and we have just seen --boundary-- which is the terminating one, haven't
> we? Shouldn't we be simply returning?
That's what I originally did, but then I realized the rest of the
handle_boundary() reads the next line of text, which is needed to continue
processing in handle_body(). :-)
Cheers,
Don
prev parent reply other threads:[~2008-08-14 1:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 22:45 [PATCH] Allow emails with boundaries to work again Don Zickus
2008-08-13 23:45 ` Junio C Hamano
2008-08-14 0:56 ` Don Zickus
2008-08-14 1:36 ` Junio C Hamano
2008-08-14 1:56 ` Don Zickus [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080814015604.GD24172@redhat.com \
--to=dzickus@redhat.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.