From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with archive (Exim 4.43)
	id 1KThGG-0002qE-FP
	for mharc-grub-devel@gnu.org; Thu, 14 Aug 2008 14:09:24 -0400
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KThGF-0002pk-4K
	for grub-devel@gnu.org; Thu, 14 Aug 2008 14:09:23 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KThGD-0002ox-HZ
	for grub-devel@gnu.org; Thu, 14 Aug 2008 14:09:22 -0400
Received: from [199.232.76.173] (port=35944 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KThGD-0002or-DZ
	for grub-devel@gnu.org; Thu, 14 Aug 2008 14:09:21 -0400
Received: from aybabtu.com ([69.60.117.155]:53991)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <rmh@aybabtu.com>) id 1KThGC-0000W4-PB
	for grub-devel@gnu.org; Thu, 14 Aug 2008 14:09:21 -0400
Received: from [192.168.10.10] (helo=thorin)
	by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.69) (envelope-from <rmh@aybabtu.com>) id 1KTh7y-0001I2-HK
	for grub-devel@gnu.org; Thu, 14 Aug 2008 20:00:50 +0200
Received: from rmh by thorin with local (Exim 4.63)
	(envelope-from <rmh@aybabtu.com>) id 1KThF0-0004nC-GS
	for grub-devel@gnu.org; Thu, 14 Aug 2008 20:08:06 +0200
Date: Thu, 14 Aug 2008 20:08:06 +0200
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Message-ID: <20080814180806.GA18309@thorin>
References: <87fxp9di59.fsf@xs4all.nl> <20080812224041.GB3141@thorin>
	<1218606980.4008.9.camel@fz.local> <87abfhb60p.fsf@xs4all.nl>
	<1218659496.25595.7.camel@fz.local> <20080813215023.GA23069@thorin>
	<1218667156.4010.5.camel@fz.local>
	<1218670230.4010.11.camel@fz.local> <87vdy4yspn.fsf@xs4all.nl>
	<1218711750.5154.11.camel@fz.local>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1218711750.5154.11.camel@fz.local>
Organization: free as in freedom
X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird!
	www.mozilla.com/thunderbird
X-Debbugs-No-Ack: true
User-Agent: Mutt/1.5.13 (2006-08-11)
X-detected-kernel: by monty-python.gnu.org: Genre and OS details not
	recognized.
Subject: Re: [PATCH] kern/err.c + disk/raid.c error handling fixes
X-BeenThere: grub-devel@gnu.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: The development of GRUB 2 <grub-devel@gnu.org>
List-Id: The development of GRUB 2 <grub-devel.gnu.org>
List-Unsubscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/grub-devel>
List-Post: <mailto:grub-devel@gnu.org>
List-Help: <mailto:grub-devel-request@gnu.org?subject=help>
List-Subscribe: <http://lists.gnu.org/mailman/listinfo/grub-devel>,
	<mailto:grub-devel-request@gnu.org?subject=subscribe>
X-List-Received-Date: Thu, 14 Aug 2008 18:09:23 -0000

On Thu, Aug 14, 2008 at 01:02:30PM +0200, Felix Zielcke wrote:
> +int
> +grub_err_printf (const char *fmt, ...)
> +{
> +  va_list ap;
> +  int ret;
> +  
> +  va_start (ap, fmt);
> +  ret = vfprintf (stderr, fmt, ap);
> +  va_end (ap);
> +
> +  return ret;
> +}
>  void *
>  xmalloc (size_t size)

Please separate functions with an empty line.  Anyway, no need to send a new
patch just for this.

Marco, is it fine to you now?

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."