From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KTjcJ-0006Bu-B2 for mharc-grub-devel@gnu.org; Thu, 14 Aug 2008 16:40:19 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KTjcE-0006A9-Ru for grub-devel@gnu.org; Thu, 14 Aug 2008 16:40:14 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KTjcC-00069G-J3 for grub-devel@gnu.org; Thu, 14 Aug 2008 16:40:13 -0400 Received: from [199.232.76.173] (port=41109 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KTjcC-00069D-Fa for grub-devel@gnu.org; Thu, 14 Aug 2008 16:40:12 -0400 Received: from aybabtu.com ([69.60.117.155]:50919) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KTjcC-0003CV-2e for grub-devel@gnu.org; Thu, 14 Aug 2008 16:40:12 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KTjTx-0001wK-4Q for grub-devel@gnu.org; Thu, 14 Aug 2008 22:31:41 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KTjay-00066T-HT for grub-devel@gnu.org; Thu, 14 Aug 2008 22:38:56 +0200 Date: Thu, 14 Aug 2008 22:38:56 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080814203856.GA23307@thorin> References: <20080808202337.3440.57502.reportbug@sylvester.jejik.com.jejik.com> <1218277583.9301.6.camel@fz.local> <489EEAC5.4080209@jejik.com> <1218471512.6939.19.camel@fz.local> <1218735245.8950.10.camel@fz.local> <20080814180353.GC5614@thorin> <1218742324.10393.8.camel@fz.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1218742324.10393.8.camel@fz.local> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Grub2 cannot find LVM volume groups with a dash (-) in the name X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Aug 2008 20:40:14 -0000 On Thu, Aug 14, 2008 at 09:32:04PM +0200, Felix Zielcke wrote: > > Try to ommit big indentation changes from the patch. If you change something > > that requires a big chunk of code to be reindented, I think it's better if you > > leave that out for readability (and mention so if you like). > > Unfortunately I couldn't get the -w option working to ignore white space > changes > svn diff --diff-cmd diff -x -up -x -w doestn't produce an unified diff, > < and > are used instead of - and + > with -x -w -x up the -w is ignored :( > > So I just need to remember this now that I either change the indention, > before commiting or I directly make 2 patches. > Luckly I can commit this now myself so I really don't need to include > this in the patches I send :) Okay, but please send the patch without indentation first, so your changes can be reviewed. -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."