From: Andi Kleen <andi@firstfloor.org>
To: Hugh Dickins <hugh@veritas.com>
Cc: Ingo Molnar <mingo@elte.hu>, Andi Kleen <andi@firstfloor.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: fix /proc/meminfo DirectMap
Date: Fri, 15 Aug 2008 15:15:30 +0200 [thread overview]
Message-ID: <20080815131530.GG19125@one.firstfloor.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0808151351220.28840@blonde.site>
On Fri, Aug 15, 2008 at 01:58:32PM +0100, Hugh Dickins wrote:
> Do we actually want these DirectMap lines in the x86 /proc/meminfo?
> I can see they're interesting to CPA developers and TLB optimizers,
> but they don't fit its usual "where has all my memory gone?" usage.
It was intended for the "why is my computer going slower" usage.
> If they are to stay, here are some fixes.
>
> 1. On x86_32 without PAE, they're not 2M but 4M pages: no need to
> mess with the internal enum, but show the right name to users.
>
> 2. Many machines can never show anything but 0 for DirectMap1G,
> so suppress that line unless direct_gbpages are really enabled.
I made them unconditional to minimize the risk of some dumb
parser not being able to deal with them. Longer term there
will be more and more machines that support them.
Admittedly that's not a very strong argument.
-Andi
next prev parent reply other threads:[~2008-08-15 13:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-15 12:58 [PATCH] x86: fix /proc/meminfo DirectMap Hugh Dickins
2008-08-15 13:15 ` Andi Kleen [this message]
2008-08-15 13:32 ` Hugh Dickins
2008-08-15 13:36 ` Andi Kleen
2008-08-15 13:45 ` Ingo Molnar
2008-08-15 13:28 ` Ingo Molnar
2008-08-15 14:30 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080815131530.GG19125@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.