From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KUjdr-0007pM-II for mharc-grub-devel@gnu.org; Sun, 17 Aug 2008 10:54:03 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KUjdq-0007p3-0X for grub-devel@gnu.org; Sun, 17 Aug 2008 10:54:02 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KUjdo-0007oq-Ek for grub-devel@gnu.org; Sun, 17 Aug 2008 10:54:01 -0400 Received: from [199.232.76.173] (port=43772 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KUjdo-0007on-BS for grub-devel@gnu.org; Sun, 17 Aug 2008 10:54:00 -0400 Received: from aybabtu.com ([69.60.117.155]:52153) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KUjdo-0006zm-0j for grub-devel@gnu.org; Sun, 17 Aug 2008 10:54:00 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KUjVE-0007MZ-7D for grub-devel@gnu.org; Sun, 17 Aug 2008 16:45:09 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KUjcQ-0002Q3-4S for grub-devel@gnu.org; Sun, 17 Aug 2008 16:52:34 +0200 Date: Sun, 17 Aug 2008 16:52:34 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080817145234.GA9153@thorin> References: <20080811203024.GA6883@thorin> <87skt99qn4.fsf@xs4all.nl> <20080816121654.GA6334@thorin> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Split of raid scan code X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Aug 2008 14:54:02 -0000 On Sat, Aug 16, 2008 at 11:20:04PM +0800, Bean wrote: > On Sat, Aug 16, 2008 at 8:16 PM, Robert Millan wrote: > > On Sat, Aug 16, 2008 at 05:07:00PM +0800, Bean wrote: > >> Hi, > >> > >> This new patch seperates raid5 and raid6 recover code from raid.c, and > >> place them in module raid5rec.mod and raid6rec.mod. The recover code > >> is only needed when some of the disk are missing or corrupted, which > >> is not common. But raid.c is installed to mbr, so size is important. > >> If there is enough room in mbr for the extra module, they can use > >> --modules option in grub-install to add these modules. > > > > I find this scary in the sense that users need to know about these modules > > to get the benefit of recovery, and even then, they also need to know they > > are affected by this problem when they install GRUB (since otherwise they > > won't be able to bootstrap). > > > > Is it possible to detect whether recover code will be needed when grub-install > > is run, and then either add the extra modules or abort with an error? > > Hi, > > grub-probe don't use the recover module, so if it have problem at > install time, user would know about it (error message would be > "raid5rec not loaded"). Sounds fine to me. But the error message is too cryptic IMHO. Consider the situation in which user was running grub-install and sees this error. Shouldn't we tell her to fix the RAID instead? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."