From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1KUkL2-0002oN-KK for mharc-grub-devel@gnu.org; Sun, 17 Aug 2008 11:38:40 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1KUkL0-0002o8-11 for grub-devel@gnu.org; Sun, 17 Aug 2008 11:38:38 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1KUkKz-0002nw-DU for grub-devel@gnu.org; Sun, 17 Aug 2008 11:38:37 -0400 Received: from [199.232.76.173] (port=42718 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1KUkKz-0002nt-8Y for grub-devel@gnu.org; Sun, 17 Aug 2008 11:38:37 -0400 Received: from aybabtu.com ([69.60.117.155]:39559) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1KUkKy-00023h-TC for grub-devel@gnu.org; Sun, 17 Aug 2008 11:38:37 -0400 Received: from [192.168.10.10] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1KUkCS-0007V4-Af for grub-devel@gnu.org; Sun, 17 Aug 2008 17:29:48 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1KUkJj-0002kz-Dq for grub-devel@gnu.org; Sun, 17 Aug 2008 17:37:19 +0200 Date: Sun, 17 Aug 2008 17:37:19 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20080817153719.GC9696@thorin> References: <20080817130119.GA22343@pina.cat> <877iaf20jx.fsf@xs4all.nl> <20080817142916.GB28198@pina.cat> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080817142916.GB28198@pina.cat> Organization: free as in freedom X-Message-Flag: Worried about Outlook viruses? Switch to Thunderbird! www.mozilla.com/thunderbird X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-detected-kernel: by monty-python.gnu.org: Genre and OS details not recognized. Subject: Re: [PATCH] Replace magic numbers by constants X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 17 Aug 2008 15:38:38 -0000 On Sun, Aug 17, 2008 at 04:29:16PM +0200, Carles Pina i Estany wrote: > 2008-08-17 Carles Pina i Estany > > * menu/normal.c (run_menu): Change magic numbers by constants > (16 by GRUB_TERM_UP and 14 by GRUB_TERM_DOWN) When reading the subject I thought it was the other way around. Would something like: "replace hardcoded numbers with macros" or "macroify numbers" etc, make it more clear? -- Robert Millan The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and how) you may access your data; but nobody's threatening your freedom: we still allow you to remove your data and not access it at all."