From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1KV6TD-0003rC-NH
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 11:16:36 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1KV6TB-0003oU-PU
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 11:16:35 -0400
Received: from [199.232.76.173] (port=45760 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1KV6TB-0003oK-Lv
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 11:16:33 -0400
Received: from bsdimp.com ([199.45.160.85]:60633 helo=harmony.bsdimp.com)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <imp@bsdimp.com>) id 1KV6TB-0004KT-5U
	for qemu-devel@nongnu.org; Mon, 18 Aug 2008 11:16:33 -0400
Date: Mon, 18 Aug 2008 09:12:45 -0600 (MDT)
Message-Id: <20080818.091245.74704979.imp@bsdimp.com>
Subject: Re: [Qemu-devel] pty/tty functions for BSD too
From: Warner Losh <imp@bsdimp.com>
In-Reply-To: <20080818142333.GQ4686@implementation.uk.xensource.com>
References: <20080818105912.GF4686@implementation.uk.xensource.com>
	<48A981F1.6070606@codemonkey.ws>
	<20080818142333.GQ4686@implementation.uk.xensource.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, samuel.thibault@ens-lyon.org

From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [Qemu-devel] pty/tty functions for BSD too
Date: Mon, 18 Aug 2008 15:23:33 +0100

> Anthony Liguori, le Mon 18 Aug 2008 09:06:41 -0500, a =E9crit :
> > Samuel Thibault wrote:
> > >In Xen, pty/tty functions are enabled for BSD too, shouldn't we en=
able
> > >them in upstream qemu too, as patched below?
> > >  =

> > =

> > And you're sure that these functions compile/work on NetBSD/OpenBSD=
?
> =

> The defines are explicit in Xen, so I guess somebody tested it.  I
> haven't myself.  I wonder why there is no FreeBSD however.

The TTY/PTY code is 4.2BSD, so everybdoy has it...  Not sure about why
no FreeBSD.  I haven't looked at the code, but I thought there was a
different fork it took..

I've noticed many times in the past that the #ifdef sun and/or #ifdef
linux code works great on FreeBSD.

Warner