From: "Yang, Sheng" <sheng.yang@intel.com>
To: kvm@vger.kernel.org
Cc: Avi Kivity <avi@qumranet.com>
Subject: Re: [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target
Date: Mon, 18 Aug 2008 09:59:13 +0800 [thread overview]
Message-ID: <200808180959.13438.sheng.yang@intel.com> (raw)
In-Reply-To: <200808131148.02834.sheng.yang@intel.com>
On Wednesday 13 August 2008 11:48:02 Yang, Sheng wrote:
> From 50a27ca42a565579e78e3545ca097a65a88cbadd Mon Sep 17 00:00:00
> 2001 From: Sheng Yang <sheng.yang@intel.com>
> Date: Wed, 13 Aug 2008 11:35:17 +0800
> Subject: [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target
>
> Seems this flags is missing during merging long ago... And this
> result in updating of libkvm.a didn't affect make process of qemu,
> which is very puzzling...
Avi, comments?
BTW: Commits 68439f0a742138188176f35bb606c4aa6b702fd3 drop this.
--
regards
Yang, Sheng
>
> Signed-off-by: Sheng Yang <sheng.yang@intel.com>
> ---
> qemu/Makefile.target | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu/Makefile.target b/qemu/Makefile.target
> index f4df081..c09af57 100644
> --- a/qemu/Makefile.target
> +++ b/qemu/Makefile.target
> @@ -741,7 +741,7 @@ firmware.o: firmware.c
> $(CC) $(HELPER_CFLAGS) $(CPPFLAGS) $(BASE_CFLAGS) -c -o $@ $<
> endif
>
> -$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a
> +$(QEMU_PROG): $(OBJS) ../libqemu_common.a libqemu.a $(DEPLIBS)
> $(CC) $(LDFLAGS) -o $@ $^ $(LIBS) $(SDL_LIBS) $(COCOA_LIBS)
> $(CURSES_LIBS) $(BRLAPI_LIBS) $(VDE_LIBS)
>
> endif # !CONFIG_USER_ONLY
> --
> 1.5.4.5
next prev parent reply other threads:[~2008-08-18 1:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 3:48 [PATCH] kvm: qemu: Add missing DEPLIBS in Makefile.target Yang, Sheng
2008-08-18 1:59 ` Yang, Sheng [this message]
2008-08-18 10:10 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200808180959.13438.sheng.yang@intel.com \
--to=sheng.yang@intel.com \
--cc=avi@qumranet.com \
--cc=kvm@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.