From: Andrew Morton <akpm@linux-foundation.org>
To: Ayaz Abdulla <aabdulla@nvidia.com>
Cc: jgarzik@pobox.com, manfred@colorfullife.com, netdev@vger.kernel.org
Subject: Re: [PATCH] forcedeth: fix checksum flag
Date: Mon, 18 Aug 2008 14:54:42 -0700 [thread overview]
Message-ID: <20080818145442.659ab3a3.akpm@linux-foundation.org> (raw)
In-Reply-To: <48A4B665.5020802@nvidia.com>
On Thu, 14 Aug 2008 18:49:09 -0400
Ayaz Abdulla <aabdulla@nvidia.com> wrote:
> This patch fixes the checksum feature advertised in device flags. The
> hardware support TCP/UDP over IPv4 and TCP/UDP over IPv6 (without IPv6
> extension headers). However, the kernel feature flags do not distinguish
> IPv6 with/without extension headers.
>
> Therefore, the driver needs to use NETIF_F_IP_CSUM instead of
> NETIF_F_HW_CSUM since the latter includes all IPv6 packets.
>
> A future patch can created to check for extension headers and perform
> software checksum calculation.
>
> Signed-off-by: Ayaz Abdulla <aabdulla@nvidia.com>
>
>
> [patch-forcedeth-ipv4csum text/plain (780B)]
> --- old/drivers/net/forcedeth.c 2008-08-14 18:37:11.000000000 -0400
> +++ new/drivers/net/forcedeth.c 2008-08-14 18:37:05.000000000 -0400
> @@ -5522,7 +5522,7 @@
> if (id->driver_data & DEV_HAS_CHECKSUM) {
> np->rx_csum = 1;
> np->txrxctl_bits |= NVREG_TXRXCTL_RXCHECK;
> - dev->features |= NETIF_F_HW_CSUM | NETIF_F_SG;
> + dev->features |= NETIF_F_IP_CSUM | NETIF_F_SG;
> dev->features |= NETIF_F_TSO;
> }
>
> @@ -5835,7 +5835,7 @@
>
> dev_printk(KERN_INFO, &pci_dev->dev, "%s%s%s%s%s%s%s%s%s%sdesc-v%u\n",
> dev->features & NETIF_F_HIGHDMA ? "highdma " : "",
> - dev->features & (NETIF_F_HW_CSUM | NETIF_F_SG) ?
> + dev->features & (NETIF_F_IP_CSUM | NETIF_F_SG) ?
> "csum " : "",
> dev->features & (NETIF_F_HW_VLAN_RX | NETIF_F_HW_VLAN_TX) ?
> "vlan " : "",
>
Is this fix needed in 2.6.25.x and 2.6.26.x?
next prev parent reply other threads:[~2008-08-18 21:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-14 22:49 [PATCH] forcedeth: fix checksum flag Ayaz Abdulla
2008-08-18 21:54 ` Andrew Morton [this message]
2008-08-19 12:58 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080818145442.659ab3a3.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=aabdulla@nvidia.com \
--cc=jgarzik@pobox.com \
--cc=manfred@colorfullife.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.