From: Dave Jones <davej@redhat.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: David Fries <david@fries.net>,
linux-kernel@vger.kernel.org, "Rafael J. Wysocki" <rjw@sisk.pl>,
Pavel Machek <pavel@ucw.cz>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] Fix i486 suspend to disk CR4 oops
Date: Mon, 18 Aug 2008 11:24:40 -0400 [thread overview]
Message-ID: <20080818152440.GA26134@redhat.com> (raw)
In-Reply-To: <20080818064120.GA28941@elte.hu>
On Mon, Aug 18, 2008 at 08:41:20AM +0200, Ingo Molnar wrote:
> diff --git a/arch/x86/kernel/efi_32.c b/arch/x86/kernel/efi_32.c
> index 4b63c8e..5cab48e 100644
> --- a/arch/x86/kernel/efi_32.c
> +++ b/arch/x86/kernel/efi_32.c
> @@ -53,7 +53,7 @@ void efi_call_phys_prelog(void)
> * directory. If I have PAE, I just need to duplicate one entry in
> * page directory.
> */
> - cr4 = read_cr4();
> + cr4 = read_cr4_safe();
>
> if (cr4 & X86_CR4_PAE) {
> efi_bak_pg_dir_pointer[0].pgd =
> @@ -91,7 +91,7 @@ void efi_call_phys_epilog(void)
> gdt_descr.size = GDT_SIZE - 1;
> load_gdt(&gdt_descr);
>
> - cr4 = read_cr4();
> + cr4 = read_cr4_safe();
>
> if (cr4 & X86_CR4_PAE) {
> swapper_pg_dir[pgd_index(0)].pgd =
Is this part really necessary ?
Why would a 486 be in EFI code?
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2008-08-18 15:53 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-18 4:03 [PATCH] Fix i486 suspend to disk CR4 oops David Fries
2008-08-18 4:14 ` Maciej W. Rozycki
2008-08-18 4:35 ` H. Peter Anvin
2008-08-18 6:04 ` Andi Kleen
2008-08-18 6:34 ` H. Peter Anvin
2008-08-18 6:42 ` Andi Kleen
2008-08-18 6:41 ` Ingo Molnar
2008-08-18 6:45 ` H. Peter Anvin
2008-08-18 9:15 ` Pavel Machek
2008-08-18 10:16 ` Rafael J. Wysocki
2008-08-18 12:58 ` David Fries
2008-08-18 13:25 ` Ingo Molnar
2008-08-18 14:41 ` Maciej W. Rozycki
2008-08-18 14:38 ` Maciej W. Rozycki
2008-08-18 22:04 ` Pavel Machek
2008-08-18 22:10 ` H. Peter Anvin
2008-08-18 15:24 ` Dave Jones [this message]
2008-08-18 16:04 ` Lennart Sorensen
2008-08-18 17:17 ` Dave Jones
2008-08-18 17:32 ` H. Peter Anvin
2008-08-18 22:02 ` Pavel Machek
2008-08-19 3:37 ` [PATCH] i486 CR4 oops, no_console_suspend David Fries
2008-08-19 9:34 ` Ingo Molnar
2008-08-19 16:07 ` H. Peter Anvin
2008-08-21 4:17 ` David Fries
2008-08-21 5:37 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080818152440.GA26134@redhat.com \
--to=davej@redhat.com \
--cc=david@fries.net \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pavel@ucw.cz \
--cc=rjw@sisk.pl \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.