Re: [PATCH]: Schedule correct qdisc in watchdog.

[Jarek Poplawski <jarkao2@gmail.com>]

On Mon, Aug 18, 2008 at 08:54:27PM -0700, David Miller wrote:
> From: Jarek Poplawski <jarkao2@gmail.com>
> Date: Mon, 18 Aug 2008 11:35:31 +0000
> 
> > pkt_sched: Add lockdep annotation for qdisc locks
> > 
> > Qdisc locks are initialized in the same function, qdisc_alloc(), so
> > lockdep can't distinguish tx qdisc lock from rx and reports "possible
> > recursive locking detected" when both these locks are taken eg. while
> > using act_mirred with ifb. This looks like a false positive. Anyway,
> > after this patch these locks will be reported more exactly.
> > 
> > Reported-by: Denys Fedoryshchenko <denys@visp.net.lb>
> > Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
> 
> Applied, thanks Jarek.
> 
> I suspect we need to apply this lock annotation to the locks
> in the static qdiscs &noop_qdisc and &noqueue_qdisc.
> 

I guess, we currently don't need this. At least ingress checks and
skipps acting for &noop_qdisc. I'd prefer to see some lockdep warning
first, or maybe you could show some scenario?

Jarek P.