All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@vyatta.com>
To: netdev@vger.kernel.org
Subject: [RFC] ipv6: protocol for address routes
Date: Tue, 19 Aug 2008 08:54:41 -0700	[thread overview]
Message-ID: <20080819085441.7b0184d1@speedy> (raw)

This fixes a problem spotted with zebra, but not sure if it is necessary a kernel problem.
With IPV6 when an address is added to an interface, Zebra creates a duplicate RIB
entry, one as a connected route, and other as a kernel route.

When an address is added to an interface the RTN_NEWADDR message causes Zebra
to create a connected route. In IPV4 when an address is added to an interface a RTN_NEWROUTE
message is set to user space with the protocol RTPROT_KERNEL. Zebra ignores these messages,
because it already has the connected route.

The problem is that route created in IPV6 has route protocol == RTPROT_BOOT.
Was this a design decision or a bug? This fixes it. Same patch applies to both
net-2.6 and stable.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>

--- a/net/ipv6/addrconf.c	2008-08-18 21:58:51.000000000 -0700
+++ b/net/ipv6/addrconf.c	2008-08-18 22:00:26.000000000 -0700
@@ -1688,6 +1688,7 @@ addrconf_prefix_route(struct in6_addr *p
 		.fc_dst_len = plen,
 		.fc_flags = RTF_UP | flags,
 		.fc_nlinfo.nl_net = dev_net(dev),
+		.fc_protocol = RTPROT_KERNEL,
 	};
 
 	ipv6_addr_copy(&cfg.fc_dst, pfx);

             reply	other threads:[~2008-08-19 15:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-19 15:54 Stephen Hemminger [this message]
2008-08-22 12:19 ` [RFC] ipv6: protocol for address routes David Miller
2008-08-23 12:17 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080819085441.7b0184d1@speedy \
    --to=shemminger@vyatta.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.