All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Jeremy Kerr <jk@ozlabs.org>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH] Explicitly use BUILD_CC and TARGET_CC
Date: Wed, 20 Aug 2008 09:02:27 +1000	[thread overview]
Message-ID: <20080819230225.GE10528@verge.net.au> (raw)
In-Reply-To: <200808192240.16919.jk@ozlabs.org>

On Tue, Aug 19, 2008 at 10:40:16PM +0800, Jeremy Kerr wrote:
> 
> > That should be fine: we just add a rule for %.o: %.S
> 
> OK, that's not going to work, because rules of the form
> 
>  list: pattern: prereq
> 
> *require* the prereqs to be build. ie, in our case:
> 
>  $(PURGATORY_OBJS): %.o: %.S
> 
> will require a .S for all .o files in PURGATORY_OBJS. Which is not what 
> we want :(
> 
> So, the solution left would be to override COMPILE.c, COMPILE.S and 
> LINK.o for target and build compiles. For example:
> 
> $(PURGATORY_OBJS): COMPILE.c = $(TARGET_CC) $(TARGET_CFLAGS) \
>                                $(TARGET_CPPFLAGS) -c
> 
> It's unlikely that a user is going to override COMPILE.c on the make 
> command-line :)
> 
> How does that sound?

Sounds fine to me.

Another option is to split up PURGATORY_OBJS and PURGATORY_SRCS based
on wheather the source is a .S or a .c file. Though I suspect your
idea is cleaner.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2008-08-19 23:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-18  3:33 [PATCH] Explicitly use BUILD_CC and TARGET_CC Jeremy Kerr
2008-08-18  7:10 ` Simon Horman
2008-08-18  7:19   ` Jeremy Kerr
2008-08-19 14:40     ` Jeremy Kerr
2008-08-19 23:02       ` Simon Horman [this message]
2008-08-19 15:38 ` Lombard, David N

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080819230225.GE10528@verge.net.au \
    --to=horms@verge.net.au \
    --cc=jk@ozlabs.org \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.